Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Traefik Proxy)!: move redirectTo => redirections #1301

Merged
merged 3 commits into from
Jan 13, 2025
Merged

fix(Traefik Proxy)!: move redirectTo => redirections #1301

merged 3 commits into from
Jan 13, 2025

Conversation

mloiseleur
Copy link
Member

What does this PR do?

Refactor redirectTo section in ports with upstream Traefik Proxy syntax.

Before

ports:
  web:
    redirectTo:
      port: websecure
      permanent: true

After

ports:
  web:
    redirections:
      entryPoint:
        to: websecure
        scheme: https
        permanent: true

Motivation

Fixes #1288

More

  • Yes, I updated the tests accordingly
  • Yes, I updated the schema accordingly
  • Yes, I ran make test and all the tests passed

@mloiseleur mloiseleur added area/documentation Improvements or additions to documentation kind/bug/fix labels Jan 10, 2025
@mloiseleur mloiseleur mentioned this pull request Jan 10, 2025
Closed
2 tasks
darkweaver87
darkweaver87 reviewed Jan 10, 2025
View reviewed changes
traefik/templates/_podtemplate.tpl Outdated
{{- end }}
{{- if $config.redirections }}
{{- with $config.redirections.entryPoint }}
{{- if and (eq .to "websecure") (ne .scheme "https") }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't assume users didn't specify:

ports:
  websecure:
    tls:
      enabled: false

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just check if the port on which we redirect has tls.enabled: true ?
We might also want to check if the to port exists.

darkweaver87
darkweaver87 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 3097704 into traefik:master Jan 13, 2025
1 check passed
@tiran133 tiran133 mentioned this pull request Jan 15, 2025
Merged
@pgumpoldsberger pgumpoldsberger mentioned this pull request Jan 15, 2025
Open
VijayakumarRavi added a commit to VijayakumarRavi/GitOps that referenced this pull request Jan 15, 2025
@VijayakumarRavi
🐛 fix: fixing traefik/traefik-helm-chart#1301
ecc4c2f 
Signed-off-by: Vijayakumar Ravi <im@vijayakumar.xyz>
@lutz108 lutz108 mentioned this pull request Jan 24, 2025
Closed
2 tasks
@kuelteabmas kuelteabmas mentioned this pull request Feb 1, 2025
Merged
@allan-lewis allan-lewis mentioned this pull request Feb 2, 2025
Closed
fma965 added a commit to fma965/f9-k3s that referenced this pull request Feb 13, 2025
@fma965
Fix traefik/traefik-helm-chart#1301
89ccdc7
@Naroh091 Naroh091 mentioned this pull request Feb 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkweaver87 darkweaver87 darkweaver87 approved these changes

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation kind/bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improved Documentation for values.yaml
3 participants
@mloiseleur @darkweaver87 @traefiker