-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #111
Open
johnkelvinhhg
wants to merge
42
commits into
tradle:devbackup1
Choose a base branch
from
ttrustwallet:dev
base: devbackup1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package: add github url
It was pointing to an incorrect url (with actual `'` on it).
📝 Make the `./shims.js` links clicable.
npm5 installs modules and changes their `package.json`::`version` field to be something like ``` "version": "https://registry.npmjs.org/rn-nodeify/-/rn-nodeify-7.0.1.tgz", ``` instead of ``` "version": "7.0.1", ``` This commit adds support for that first type of string but also supports npm4.
Support npm5
…acks run on Windows
* Add yarn argument to control install command * Use lockfile to resolve installed pkg version when doing semver check
- require newer react-native-crypto 2.1.0 - Add extra reminder in README to run 'react-native link' - bump version (minor)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh repo clone trustwallet/dapps-browser