Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TrackCandidate error rescale + overlap hits #88

Merged
merged 7 commits into from
Apr 27, 2022
Merged

TrackCandidate error rescale + overlap hits #88

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c5527fc
Add TrackCandidate error rescale x100
mmasciov Apr 8, 2022
61022ac
Relax selection for overlap hits
mmasciov Apr 8, 2022
389c3c7
code-format
mmasciov Apr 8, 2022
c4918f8
Use existing pTCutOverlap, set to zero, for overlap hit selection
mmasciov Apr 14, 2022
405549a
Improve description in comment
mmasciov Apr 14, 2022
f1ead0c
Make error rescaling before final fit configurable
mmasciov Apr 14, 2022
2158049
Format commented lines
mmasciov Apr 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RecoTracker/MkFit/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ $ runTheMatrix.py -l <workflow(s)> --apply 2 --command "--procModifiers tracking
* *maxHolesPerCand:* maximum number of allowed holes on a candidate
* *maxConsecHoles:* maximum number of allowed consecutive holes on a candidate
* *chi2Cut_min:* minimum chi2 cut for accepting a new hit
* *chi2CutOverlap:* chi2 cut for accepting an overlap hit
* *chi2CutOverlap:* chi2 cut for accepting an overlap hit (currently NOT used)
* *pTCutOverlap:* pT cut below which the overlap hits are not picked up

#### Seed cleaning params (based on elliptical dR-dz cut)
Expand Down
2 changes: 2 additions & 0 deletions RecoTracker/MkFit/plugins/MkFitOutputConverter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,8 @@ TrackCandidateCollection MkFitOutputConverter::convertCandidates(const MkFitOutp
const auto seedIndex = cand.label();
LogTrace("MkFitOutputConverter") << " from seed " << seedIndex << " seed hits";

if (mkFitOutput.propagatedToFirstLayer())
mmasciov marked this conversation as resolved.
Show resolved Hide resolved
fts.rescaleError(100.);
auto tsosDet =
mkFitOutput.propagatedToFirstLayer()
? convertInnermostState(fts, recHits, propagatorAlong, propagatorOpposite)
Expand Down
2 changes: 1 addition & 1 deletion RecoTracker/MkFitCore/interface/IterationConfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ namespace mkfit {
int maxConsecHoles = 1;
float chi2Cut_min = 15.0;
float chi2CutOverlap = 3.5;
float pTCutOverlap = 1.0;
float pTCutOverlap = 0.0;

//seed cleaning params
float c_ptthr_hpt = 2.0;
Expand Down
2 changes: 1 addition & 1 deletion RecoTracker/MkFitCore/src/CandCloner.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ namespace mkfit {
if (n_pushed >= mp_iteration_params->maxCandsPerSeed)
break;

// set the overlap if we have a true hit and pT > pTCutOverlap
// set the overlap if we have a true hit and pT > pTCutOverlap (=0 by default)
mmasciov marked this conversation as resolved.
Show resolved Hide resolved
HitMatch *hm;
if (tc.pT() > mp_iteration_params->pTCutOverlap && h2a.hitIdx >= 0 &&
(hm = ccand[h2a.trkIdx].findOverlap(h2a.hitIdx, h2a.module))) {
Expand Down
8 changes: 5 additions & 3 deletions RecoTracker/MkFitCore/src/MkFinder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1074,7 +1074,8 @@ namespace mkfit {
newcand.setScore(getScoreCand(newcand, true /*penalizeTailMissHits*/, true /*inFindCandidates*/));
newcand.setOriginIndex(m_CandIdx(itrack, 0, 0));

if (chi2 < m_iteration_params->chi2CutOverlap) {
// To apply a fixed cut instead of dynamic cut for overlap: m_iteration_params->chi2CutOverlap
if (chi2 < max_c2) {
CombCandidate &ccand = *newcand.combCandidate();
ccand[m_CandIdx(itrack, 0, 0)].considerHitForOverlap(
hit_idx, layer_of_hits.refHit(hit_idx).detIDinLayer(), chi2);
Expand Down Expand Up @@ -1231,8 +1232,9 @@ namespace mkfit {
nHitsAdded[itrack]++;
const int hit_idx = m_XHitArr.At(itrack, hit_cnt, 0);

// Register hit for overlap consideration, here we apply chi2 cut
if (chi2 < m_iteration_params->chi2CutOverlap) {
// Register hit for overlap consideration, if chi2 cut is passed
// To apply a fixed cut instead of dynamic cut for overlap: m_iteration_params->chi2CutOverlap
if (chi2 < max_c2) {
ccand[m_CandIdx(itrack, 0, 0)].considerHitForOverlap(
hit_idx, layer_of_hits.refHit(hit_idx).detIDinLayer(), chi2);
}
Expand Down