Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for excellon drill files w/ leading/trailing set in M71/M72 line #96

Merged

Conversation

davidworkman9
Copy link
Contributor

Ran into a drill file recently that started off like this:

M48
M72,LZ

I don't know that this is official syntax, but this adds support for files like it.

Note this is completely untested. I started writing tests, but couldn't figure out how to get them to run. It appears there's a bunch of unmarked dependencies required to get a test environment working.

@mcous
Copy link
Member

mcous commented Dec 17, 2018

Thanks @davidworkman9, this looks like a good change. M71 and M72 are listed as valid inch and metric commands in this archived version of the Excellon "spec".

As for tests, it looks like a sub-dependency was unpublished from npm for some reason, so CI is broken because that version doesn't exist in the lockfile. I'll need to fix that up, and I'll ping you here once it's done so you can rebase. Sorry for the inconvenience.

Once that's fixed, make sure you're in the repository root and do:

npm install
npm test

(Same instructions as in the "contributing" section of the readme)

@mcous
Copy link
Member

mcous commented Dec 17, 2018

CI job was fixed with #97. I'd recommend rebasing your branch and giving tests another shot!

@mcous
Copy link
Member

mcous commented Dec 19, 2018

@davidworkman9 were you able to make any progress on rebasing?

@davidworkman9 davidworkman9 force-pushed the excellon-trailing-with-m-measuring-mode branch from a159747 to 41d3e69 Compare December 19, 2018 17:59
@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #96 into next will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next      #96   +/-   ##
=======================================
  Coverage   94.26%   94.26%           
=======================================
  Files          49       49           
  Lines        2058     2058           
=======================================
  Hits         1940     1940           
  Misses        118      118
Impacted Files Coverage Δ
packages/gerber-parser/lib/_parse-drill.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2adf8ca...03a3985. Read the comment docs.

@davidworkman9
Copy link
Contributor Author

Thanks @mcous I was able to get a test environment running after rebasing.

Copy link
Member

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This looks great

@mcous mcous merged commit 11066d2 into tracespace:next Dec 20, 2018
@mcous
Copy link
Member

mcous commented Dec 20, 2018

Released as:

  • @tracespace/cli: 4.0.0-next.17
  • gerber-parser: 4.0.0-next.17
  • gerber-to-svg: 4.0.0-next.17
  • pcb-stackup: 4.0.0-next.17

@davidworkman9
Copy link
Contributor Author

Thanks @mcous !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants