Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/setup #136

Merged
merged 10 commits into from
Jun 7, 2024
Merged

Refactor/setup #136

merged 10 commits into from
Jun 7, 2024

Conversation

Pugma
Copy link
Contributor

@Pugma Pugma commented May 23, 2024

もろもろの環境構築を移動してきた影響でgo run {task} initが効かなくなるなど、まだいくつか修正点はあるが一つのたたき台として

@hijiki51
Copy link
Member

hijiki51 commented May 23, 2024

せっかくMarkdown(いやHTMLかけるのはそうなんだけど)つかってるのにHTML直書きするのはメンテ性/可読性落ちるからCode Groupsぐらいに収めてほしい

もしくは別ページにしちゃうか

https://vitepress.dev/guide/markdown#code-groups

@Pugma
Copy link
Contributor Author

Pugma commented May 23, 2024

う〜ん…
やっぱり Markdown の範囲でうまくやりくりするの難しいですね
結構 OS でやること変わるんで、もうページごと分けちゃったほうがよさそうかもです

@Pugma Pugma requested a review from Takeno-hito June 7, 2024 05:15
@Pugma Pugma marked this pull request as ready for review June 7, 2024 05:15
@Pugma Pugma requested review from mathsuky and alter334 June 7, 2024 05:39
Copy link
Contributor

@alter334 alter334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

標記について変えた方が良いかも?という部分だけレビューしました
技術的な側面でまだ気づいていないミスがあったらすみません

docs/chapter1/section1/0_setup-windows.md Outdated Show resolved Hide resolved
docs/chapter1/section1/0_setup-windows.md Outdated Show resolved Hide resolved
docs/chapter1/section1/0_setup-windows.md Show resolved Hide resolved
docs/chapter1/section1/1_setup-unix.md Outdated Show resolved Hide resolved
docs/chapter1/section1/1_setup-unix.md Show resolved Hide resolved
docs/chapter1/section1/1_setup-unix.md Outdated Show resolved Hide resolved
Copy link
Contributor

@alter334 alter334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

環境構築部分のMacWindows誤表記等についての修正

@alter334 alter334 merged commit 64cc929 into main Jun 7, 2024
3 checks passed
@alter334 alter334 deleted the refactor/setup branch June 7, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants