Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stickyなヘッダーをなくした (一番上のfixedなヘッダーのみ) #939

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

cp-20
Copy link
Contributor

@cp-20 cp-20 commented Jul 22, 2024

なぜやるか

close #830

やったこと

stickyなヘッダーをなくした (一番上のfixedなヘッダーのみにした)

やらなかったこと

資料

@cp-20 cp-20 requested a review from eyemono-moe July 22, 2024 13:59
Copy link

Preview (prod backend + PR dashboard) → https://939.ns-preview.trapti.tech/

Copy link
Contributor

@eyemono-moe eyemono-moe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントした3点について確認お願いします! 🙏

dashboard/src/components/layouts/WithNav.tsx Show resolved Hide resolved
dashboard/src/components/layouts/WithNav.tsx Show resolved Hide resolved
dashboard/src/components/layouts/WithNav.tsx Show resolved Hide resolved
@cp-20 cp-20 merged commit 2221340 into main Jul 30, 2024
17 checks passed
@cp-20 cp-20 deleted the fix/sticky-header branch July 30, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ヘッダーのsticky部分を減らす
2 participants