Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translations #88

Merged
merged 4 commits into from
Dec 20, 2022
Merged

Fix translations #88

merged 4 commits into from
Dec 20, 2022

Conversation

RedVortexDev
Copy link
Contributor

@RedVortexDev RedVortexDev commented Dec 15, 2022

Formatting JSON, fixing a translation not having a JSON format and adding a comma, no changes to actual translation, but just making it actually work lol

@RedVortexDev
Copy link
Contributor Author

Note that I formatted based on 4 spaces like found in the mod's java source code

@tr7zw
Copy link
Owner

tr7zw commented Dec 15, 2022

Hm, these are badly formatted too? Using tabs instead of spaces.

@tr7zw
Copy link
Owner

tr7zw commented Dec 15, 2022

I use VSCodes (built in?) formatter, that matches the formatting I also use for java code.

@RedVortexDev
Copy link
Contributor Author

Go to a java file, what do you see in the bottom right? It should tell you how you indent (tabs/spaces: num)

@tr7zw
Copy link
Owner

tr7zw commented Dec 17, 2022

It's the normal 2 spaces instead of tabs. The lang file was probably copied from another project and not formatted, that's why it had 4 spaces. In the end I don't really care, but tabs are a bit of a nope.

@RedVortexDev
Copy link
Contributor Author

well I used spaces so is that alr

@tr7zw
Copy link
Owner

tr7zw commented Dec 17, 2022

grafik
The pr is using tabs.

@RedVortexDev
Copy link
Contributor Author

My bad, fixed

@RedVortexDev
Copy link
Contributor Author

RedVortexDev commented Dec 20, 2022

Oof, i used 4 spaces

@RedVortexDev
Copy link
Contributor Author

now it should be fixed

@tr7zw tr7zw merged commit 45884ef into tr7zw:1.19 Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants