-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: allow passing scanning timeouts #37
Feature: allow passing scanning timeouts #37
Conversation
@fragilehm thanks! One question |
@tr3v3r yes tested on both iOS and Android. The param passed will be null and when getting the int value from a dictionary (which is null in this case) it will return 0 and since 0 is false the default value (5000) will be assigned. |
I’ll prepare new release soon and let you know. Thanks for contribution!) |
Alright, thanks for your quick replies! |
@tr3v3r do you have an ETA when the new release will come out? We can work around by patching the changes, but for the maintenance's sake, it is always better to get it directly from the repo. Thanks in advance! |
@fragilehm hi. Actually I’m trying to release since yesterday, but no luck because of poor internet connection at the place where I currently located( . So no worry I’ll do my best to resolve this issue |
@fragilehm just released version 1.5.0. Please check if everything works as expected |
…timeout Feature: allow passing scanning timeouts
#Description
On Android 11 the default scanning timeout of 5 seconds wasn't consistently getting the results, on iOS tho 5 seconds seems to be a good default with a consistent result. So this PR adds two fields to the
discover
method:to allow users to pass custom timeouts depending on the OS.