Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: allow passing scanning timeouts #37

Merged
merged 5 commits into from
Nov 16, 2021
Merged

Feature: allow passing scanning timeouts #37

merged 5 commits into from
Nov 16, 2021

Conversation

fragilehm
Copy link
Contributor

#Description

On Android 11 the default scanning timeout of 5 seconds wasn't consistently getting the results, on iOS tho 5 seconds seems to be a good default with a consistent result. So this PR adds two fields to the discover method:

scanningTimeoutIOS,
scanningTimeoutAndroid

to allow users to pass custom timeouts depending on the OS.

@tr3v3r
Copy link
Owner

tr3v3r commented Nov 16, 2021

@fragilehm thanks! One question
Is it still possible to use discover without arguments from js?
Have you tested on iOS?

@fragilehm
Copy link
Contributor Author

@fragilehm thanks! One question Is it still possible to use discover without arguments from js? Have you tested on iOS?

@tr3v3r yes tested on both iOS and Android. The param passed will be null and when getting the int value from a dictionary (which is null in this case) it will return 0 and since 0 is false the default value (5000) will be assigned.

@tr3v3r tr3v3r merged commit b94875e into tr3v3r:main Nov 16, 2021
@tr3v3r
Copy link
Owner

tr3v3r commented Nov 16, 2021

I’ll prepare new release soon and let you know. Thanks for contribution!)

@fragilehm
Copy link
Contributor Author

I’ll prepare new release soon and let you know. Thanks for contribution!)

Alright, thanks for your quick replies!

@fragilehm
Copy link
Contributor Author

@tr3v3r do you have an ETA when the new release will come out? We can work around by patching the changes, but for the maintenance's sake, it is always better to get it directly from the repo. Thanks in advance!

@tr3v3r
Copy link
Owner

tr3v3r commented Nov 19, 2021

@fragilehm hi. Actually I’m trying to release since yesterday, but no luck because of poor internet connection at the place where I currently located( . So no worry I’ll do my best to resolve this issue

@tr3v3r
Copy link
Owner

tr3v3r commented Nov 22, 2021

@fragilehm just released version 1.5.0. Please check if everything works as expected

tr3v3r added a commit that referenced this pull request Jan 15, 2022
…timeout

Feature: allow passing scanning timeouts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants