-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get serialnumber from usb #3
Get serialnumber from usb #3
Conversation
JesperBadstue
commented
Mar 16, 2021
- Added parameter for getting serial number from usb during discovery.
- Formatting updates.
Moreover, I think we should have a possibility to get SN using any type of connection. |
I agree that it would be best to get the serialnumber from the An example output of this PR is: Options for the discover would be I dont think the DiscoveryListener returns the serial number. From what I can see from you screenshot it means that we can connect to a usb device by using the serial. The serial seems to only be available from |
Ok. I've got your point. Since your task is too specific, I suppose we need to make some changes before merging. |
android/src/main/java/com/reactnativeescposprinter/EscPosPrinterDiscoveryModule.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativeescposprinter/EscPosPrinterDiscoveryModule.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativeescposprinter/EscPosPrinterDiscoveryModule.java
Outdated
Show resolved
Hide resolved
…tion from serialNumber to usbSerialNumber. Updated documentation
If you still want to implement the usage og |
But anyway if we really need it I'll add it. |
Aaah, that explains why the function did not really work for me :) I was sure that I checked that it was supported but apparently I did not. |
It's strange for me that this method works on limited printer series. Could you please resolve conversations after you make corresponding changes? I'll test it on iOS as well soon ( I don't remember if it's OK to pass params without declaring it on the native side - it may cause crash ) |
Merged. I'll test on iOS today later on and push a new version to npm. Thanks |