Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changing language and smooth text for Android #26

Merged
merged 9 commits into from
Oct 20, 2021
Merged

Conversation

shaneCSW
Copy link
Contributor

Hi,

I add two functions for Android

  • changing language at init()
  • smooth text in Printing methods

I didn't finish for iOS well, because I could not build the app for iOS with latest version of the library from GitHub.
But installing the library from npmjs(NPM), there has no error when building the app for iOS.

@tr3v3r
Copy link
Owner

tr3v3r commented Oct 18, 2021

@shaneCSW Hi!
Thank's for the contribution!

I'll take a look in the short term.

Just to clarify: what do you mean by could not build the app for iOS with latest version of the library from GitHub ?

Do you mean release or dev build?

@tr3v3r
Copy link
Owner

tr3v3r commented Oct 18, 2021

Could you please push changes for iOS as well so I try to debug what could went wrong?

@shaneCSW
Copy link
Contributor Author

I found that both versions of GitHub and NPM are the same as 1.1.0.

The error of building :

ld: symbol(s) not found for architecture x86_64
...
Undefined symbol: _OBJC_CLASS_$_Epos2BluetoothConnection
Undefined symbol: _OBJC_CLASS_$_Epos2Printer
Undefined symbol: _OBJC_CLASS_$_Epos2FilterOption
Undefined symbol: _OBJC_CLASS_$_Epos2Discovery

It seems that I miss something when I building with the library from GitHub.

I use react-native 0.64.2 and install the library: npm install "git://github.com/tr3v3r/react-native-esc-pos-printer.git" --save, then I cmd pod install at ios folder.
Could you let me what I missing from the setting?

Thanks.

@tr3v3r
Copy link
Owner

tr3v3r commented Oct 19, 2021

@shaneCSW as I understood via NPM everything is works?

If so I'll try also to use github version to figure out what's the problem

@shaneCSW
Copy link
Contributor Author

@tr3v3r , yes, install via NPM is works.

And I'm sorry that I didn't read INSTALLATION.md before modifying, so I miss something, like LFS and Commit message convention, etc.

I'm trying to fix my branch code and complement the example code.

@tr3v3r
Copy link
Owner

tr3v3r commented Oct 19, 2021

@shaneCSW Could you also add iOS-related code, please?

@tr3v3r
Copy link
Owner

tr3v3r commented Oct 20, 2021

@shaneCSW Looks good! Thanks a lot.
Left a tiny comment.

BTW. Can you confirm that you've tested it on Android and iOS?

@shaneCSW
Copy link
Contributor Author

@tr3v3r Hi!

I have tested it with TM_M10 on Android 7.1.2 TV Box and simulator of iPad, via Network.

About changing language, I only test for EPOS2_LANG_ZH_TW, and it could print Chinese well.

@tr3v3r
Copy link
Owner

tr3v3r commented Oct 20, 2021

@shaneCSW Thanks for sharing!
If you could resolve the comment about the default lang. value, I'd merge and prepare release today.

@tr3v3r tr3v3r merged commit f38a178 into tr3v3r:main Oct 20, 2021
@tr3v3r
Copy link
Owner

tr3v3r commented Oct 21, 2021

@shaneCSW see release 1.2.0
Thanks for the help!

@shaneCSW
Copy link
Contributor Author

@tr3v3r Thank you for the information.

@shaneCSW shaneCSW deleted the dev branch October 21, 2021 07:02
tr3v3r added a commit that referenced this pull request Jan 15, 2022
Add changing language and smooth text for Android
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants