FAPI: Eventlog add H-CRTM and different locality support. #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuergenReppSIT
force-pushed
the
fapi-fix-eventlog-hcrtm-localiity
branch
8 times, most recently
from
35496a2
to
230491d
Compare
* For H-CRTM events pcr0 has to be initialized with 4. * A different locality can be set in an event with a startup locality signature. To enable the implementation of a corresponding unit test the function ifapi_check_profile_pcr_selection was splitted into two functions. The new function ifapi_calculate_pcrs is used in the unit test to check whether the expected pcr0 is computed from the event list computed from the binary H-CRTM firmware file. The pcr extension during parsing the firmware was removed. The computed pcr values were not used. The computation of the pcrs based on the replay of the eventlog is caried out by the new function ifapi_calculate_pcrs. Fixes tpm2-software#2672. Signed-off-by: Juergen Repp <juergen_repp@web.de>
JuergenReppSIT
force-pushed
the
fapi-fix-eventlog-hcrtm-localiity
branch
from
230491d
to
95a50b1
Compare
Codecov Report
@@ Coverage Diff @@
## master #2685 +/- ##
==========================================
+ Coverage 82.57% 82.61% +0.03%
==========================================
Files 368 368
Lines 42980 42991 +11
==========================================
+ Hits 35491 35517 +26
+ Misses 7489 7474 -15
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JuergenReppSIT
added a commit
to JuergenReppSIT/tpm2-tss
that referenced
this pull request
Nov 9, 2023
Based on tpm2-software#2685 In the function spi_tpm_helper_read_sts_reg the result is converted back to the correct endianess. Addresses tpm2-software#2531 Signed-off-by: Juergen Repp <juergen_repp@web.de>
JuergenReppSIT
added a commit
to JuergenReppSIT/tpm2-tss
that referenced
this pull request
Nov 28, 2023
Based on tpm2-software#2685 In the function spi_tpm_helper_read_sts_reg the result is converted back to the correct endianess. Addresses tpm2-software#2531 Co-authored-by: Lukas Märdian <slyon@ubuntu.com> Signed-off-by: Juergen Repp <juergen_repp@web.de>
AndreasFuchsTPM
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable the implementation of a corresponding unit test the function ifapi_check_profile_pcr_selection was splitted into two functions. The new function ifapi_calculate_pcrs is used in the unit test to check whether the expected pcr0 is computed from the event list computed from the binary H-CRTM firmware file.
Fixes #2672.
Signed-off-by: Juergen Repp juergen_repp@web.de