Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCTI-SPI-LTT2GO: Correct naming from lt2go to ltt2go #2653

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

PaulKissinger
Copy link
Contributor

@PaulKissinger PaulKissinger commented Jul 11, 2023

The product is called LetsTrust-TPM2Go.
This should be reflected in all references as well as the file names.

Signed-off-by: Paul Kissinger paul.kissinger@letstrust.de

@PaulKissinger PaulKissinger changed the title Rename lt2Go to ltt2g Rename lt2Go to ltt2go Jul 11, 2023
@PaulKissinger PaulKissinger changed the title Rename lt2Go to ltt2go TCTI-SPI-LTT2GO: Correct naming from ltl2go to ltt2go Jul 11, 2023
@joholl
Copy link
Collaborator

joholl commented Jul 12, 2023

Depends on #2652.

With this PR, there are no instances (file content and file names) containing the old name anymore. Also, we have never released this tcti, so we can rename this before we set it in stone with the next release.

LGTM.

@JuergenReppSIT let me know if you disagree.

@PaulKissinger PaulKissinger marked this pull request as ready for review July 12, 2023 07:55
@JuergenReppSIT
Copy link
Member

@JuergenReppSIT let me know if you disagree.

I would agree and will also change the name in the milestone for 4.0.2.

JuergenReppSIT
JuergenReppSIT previously approved these changes Jul 12, 2023
@JuergenReppSIT JuergenReppSIT self-requested a review July 12, 2023 08:21
@JuergenReppSIT
Copy link
Member

@PaulKissinger Could you please resolve the conflicts of this pr.

change naming in all files also filenames was corrected

Signed-off-by: Paul Kissinger <paul.kissinger@letstrust.de>
@PaulKissinger PaulKissinger reopened this Jul 12, 2023
@PaulKissinger PaulKissinger changed the title TCTI-SPI-LTT2GO: Correct naming from ltl2go to ltt2go TCTI-SPI-LTT2GO: Correct naming from lt2go to ltt2go Jul 12, 2023
@PaulKissinger
Copy link
Contributor Author

@PaulKissinger Could you please resolve the conflicts of this pr.

@JuergenReppSIT it is done.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #2653 (05bf96a) into master (dfb4cd0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2653   +/-   ##
=======================================
  Coverage   82.54%   82.54%           
=======================================
  Files         368      368           
  Lines       42938    42938           
=======================================
  Hits        35445    35445           
  Misses       7493     7493           
Impacted Files Coverage Δ
src/tss2-tcti/tcti-spi-ltt2go.c 56.94% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joholl joholl self-requested a review July 12, 2023 09:06
@JuergenReppSIT JuergenReppSIT merged commit dcec28b into tpm2-software:master Jul 12, 2023
50 checks passed
@PaulKissinger PaulKissinger deleted the Rename branch July 18, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants