Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is FAPI supposed to work without HAVE_CONFIG_H? #2660

Closed
Akuli opened this issue Jul 13, 2023 · 1 comment · Fixed by #2662
Closed

Is FAPI supposed to work without HAVE_CONFIG_H? #2660

Akuli opened this issue Jul 13, 2023 · 1 comment · Fixed by #2662

Comments

@Akuli
Copy link

Akuli commented Jul 13, 2023

In a project I am working on, #include <config.h> tends to pick up whatever garbage is already in the include path and cannot be used. So I added a file that #undefs HAVE_CONFIG_H.

Turns out that wasn't enough, and I also had to include <ctype.h> in my new file:

#ifdef HAVE_CONFIG_H
#include <config.h>
#include <dirent.h>
#include <ctype.h>
#endif

Are the standard-library includes supposed to be inside the ifdef?

@JuergenReppSIT
Copy link
Member

Are the standard-library includes supposed to be inside the ifdef

No I will fix it.

JuergenReppSIT added a commit to JuergenReppSIT/tpm2-tss that referenced this issue Jul 15, 2023
The standard-library includes should be inside the ifdef?
Fixes: tpm2-software#2660

Signed-off-by: Juergen Repp <juergen_repp@web.de>
JuergenReppSIT added a commit that referenced this issue Jul 16, 2023
The standard-library includes should be inside the ifdef?
Fixes: #2660

Signed-off-by: Juergen Repp <juergen_repp@web.de>
AndreasFuchsTPM pushed a commit that referenced this issue Jan 30, 2024
The standard-library includes should be inside the ifdef?
Fixes: #2660

Signed-off-by: Juergen Repp <juergen_repp@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants