Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hopefully next #564

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Hopefully next #564

wants to merge 9 commits into from

Conversation

whooo
Copy link
Contributor

@whooo whooo commented Feb 10, 2024

Branch to keep all fixes and new features in one place to ensure that they work together and for easier installation.

@whooo
test: disable pcr_set_auth_value and pcr_set_auth_policy tests for swtpm
2a17555 
Since [commit][1] in libtpms setting auth values/policies for PCRs are no longer supported.

[1]: stefanberger/libtpms@af4fc0e

Signed-off-by: Erik Larsson <who+github@cnackers.org>
@whooo
internal/crypto: fix _MyRSAPrivateNumbers with cryptograpy >= 42.0.1
4ba354e 
RSAPrivateNumbers was moved to a rust implementation in 42.0.1.
So inheritance is no longer possible, so turn the class into a
wrapper instead of a subclass.

Fixes tpm2-software#561

Signed-off-by: Erik Larsson <who+github@cnackers.org>
@whooo
add/fix type hinting across the code base.
d21b0b9 
Ignore the encoding module for now, waiting for the tools support
to be removed.

Signed-off-by: Erik Larsson <who+github@cnackers.org>
@whooo
encoding: add deprecation warning to tools_encdec
cb4de1b 
Signed-off-by: Erik Larsson <who+github@cnackers.org>
@whooo
cryptography: add module for using TPM keys with the cryptography module
74c2644 
This implements the necessary interfaces to use RSA and ECC keys with the
cryptography modules.
Enabling for example creating a CA or CSR with TPM-backed keys.

Signed-off-by: Erik Larsson <who+github@cnackers.org>
@whooo
ci: cache pip cache
de4d947 
Use setup.cfg as the basis for the cache key to invalidate the cache
if the dependencies are updated.

Signed-off-by: Erik Larsson <who+github@cnackers.org>
@whooo
ci: cache the simulator binaries/libraries
04ba127 
No need to rebuild for each CI job so cache them and reuse if available.

Signed-off-by: Erik Larsson <who+github@cnackers.org>
@whooo
ci: cache tpm2-tools binaries
6456422 
Cache tpm2-tools unless it's build from master and keep it per tss2 version.

Signed-off-by: Erik Larsson <who+github@cnackers.org>
@whooo
ci: cache the tpm2-tss install
96f7c57 
Signed-off-by: Erik Larsson <who+github@cnackers.org>
@codecov Codecov
Copy link

codecov bot commented Feb 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.15511% with 86 lines in your changes are missing coverage. Please review.

Project coverage is 90.82%. Comparing base (140ca4a) to head (96f7c57).
Report is 5 commits behind head on master.

Files Patch % Lines
src/tpm2_pytss/internal/crypto.py 81.88% 13 Missing and 10 partials ⚠️
src/tpm2_pytss/types.py 85.39% 8 Missing and 5 partials ⚠️
src/tpm2_pytss/utils.py 35.29% 6 Missing and 5 partials ⚠️
src/tpm2_pytss/internal/utils.py 79.48% 5 Missing and 3 partials ⚠️
src/tpm2_pytss/ESAPI.py 78.26% 5 Missing ⚠️
src/tpm2_pytss/TCTI.py 86.11% 3 Missing and 2 partials ⚠️
src/tpm2_pytss/constants.py 91.93% 4 Missing and 1 partial ⚠️
src/tpm2_pytss/FAPI.py 96.80% 3 Missing and 1 partial ⚠️
src/tpm2_pytss/cryptography.py 97.56% 2 Missing and 2 partials ⚠️
src/tpm2_pytss/TCTISPIHelper.py 82.35% 2 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #564      +/-   ##
==========================================
- Coverage   91.57%   90.82%   -0.76%     
==========================================
  Files          17       18       +1     
  Lines        7017     7312     +295     
  Branches     1012     1076      +64     
==========================================
+ Hits         6426     6641     +215     
- Misses        418      469      +51     
- Partials      173      202      +29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@salahcoronya salahcoronya mentioned this pull request Feb 13, 2024
Closed
@williamcroberts
Copy link
Member

As you pull features, the CI loop should be testing it, so their should be no need for something like this. You just don't merge something that causes a regression. Can we close this?

@williamcroberts
Copy link
Member

Whoops, hit close, lets discuss what to do with this.

@whooo
Copy link
Contributor Author

whooo commented Mar 25, 2024

As you pull features, the CI loop should be testing it, so their should be no need for something like this. You just don't merge something that causes a regression. Can we close this?

I just forgot to mark it as a draft, the CI loop was broken due to changes/bugs in upstream projects

@whooo whooo marked this pull request as draft March 25, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whooo @williamcroberts