-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mypy checking #472
Draft
williamcroberts
wants to merge
7
commits into
tpm2-software:master
Choose a base branch
from
williamcroberts:fix-mypy-checking
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fix mypy checking #472
williamcroberts
wants to merge
7
commits into
tpm2-software:master
from
williamcroberts:fix-mypy-checking
Commits on Nov 21, 2022
-
mypy: setup for static analysis
mypy is a static analyzer for Python using the Python3 typehints as meta data. See the below link for more information: - https://mypy.readthedocs.io/en/stable/index.html Signed-off-by: William Roberts <william.c.roberts@intel.com>
William Roberts committedNov 21, 2022 Configuration menu - View commit details
-
Copy full SHA for c2c78d1 - Browse repository at this point
Copy the full SHA c2c78d1View commit details -
Signed-off-by: William Roberts <william.c.roberts@intel.com>
William Roberts committedNov 21, 2022 Configuration menu - View commit details
-
Copy full SHA for 38d9535 - Browse repository at this point
Copy the full SHA 38d9535View commit details -
Fixes: test/test_fapi.py:84: error: Incompatible types in assignment (expression has type "bytes", variable has type "Hash") test/test_fapi.py:85: error: Incompatible return value type (got "Hash", expected "bytes") Signed-off-by: William Roberts <william.c.roberts@intel.com>
William Roberts committedNov 21, 2022 Configuration menu - View commit details
-
Copy full SHA for ebcd827 - Browse repository at this point
Copy the full SHA ebcd827View commit details -
mypy: drop option --ignore-missing-imports
Drop the nuclear option of --ignore-missing-imports and add a more targeted approach to ignoring libraries without type information. This just makes sure that tpm2-pytss internal modules themselves don't accidentally get ignored. Signed-off-by: William Roberts <william.c.roberts@intel.com>
William Roberts committedNov 21, 2022 Configuration menu - View commit details
-
Copy full SHA for dc1efc2 - Browse repository at this point
Copy the full SHA dc1efc2View commit details -
tpm2_pytss.internal: add py.typed
Signed-off-by: William Roberts <william.c.roberts@intel.com>
William Roberts committedNov 21, 2022 Configuration menu - View commit details
-
Copy full SHA for 75b7679 - Browse repository at this point
Copy the full SHA 75b7679View commit details -
mypy: get checker working better
Signed-off-by: William Roberts <william.c.roberts@intel.com>
William Roberts committedNov 21, 2022 Configuration menu - View commit details
-
Copy full SHA for 6e58567 - Browse repository at this point
Copy the full SHA 6e58567View commit details -
Signed-off-by: William Roberts <william.c.roberts@intel.com>
William Roberts committedNov 21, 2022 Configuration menu - View commit details
-
Copy full SHA for 336aa16 - Browse repository at this point
Copy the full SHA 336aa16View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.