Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update composer dependencies #22

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Conversation

MohannadNaj
Copy link
Contributor

@MohannadNaj MohannadNaj commented Dec 24, 2023

Currently, the "post-autoload-dump": "@php ./vendor/bin/testbench package:discover" script in PHP 8.3.1 is failing due to:
https://github.com/mohannadnaj-forks/laravel-query-expressions/actions/runs/7284668115/job/19850377090?pr=7#step:4:479

> @php ./vendor/bin/testbench package:discover --ansi
PHP Fatal error:  Orchestra\Testbench\Foundation\Console\TestCommand::getConfigurationFile() has #[\Override] attribute, but no matching parent method exists in /home/runner/work/laravel-query-expressions/laravel-query-expressions/vendor/orchestra/testbench-core/src/Foundation/Console/TestCommand.php on line 165

   Symfony\Component\ErrorHandler\Error\FatalError 

  Orchestra\Testbench\Foundation\Console\TestCommand::getConfigurationFile() has #[\Override] attribute, but no matching parent method exists

  at vendor/orchestra/testbench-core/src/Foundation/Console/TestCommand.php:165
    161▕      *
    162▕      * @return string
    163▕      */
    164▕     #[\Override]
  ➜ 165▕     protected function getConfigurationFile()
    166▕     {
    167▕         return $this->phpUnitConfigurationFile();
    168▕     }
    169▕ }

Probably it wasn't reflected in the CI because the relevent testbench release was 5 days ago https://github.com/orchestral/testbench/releases/tag/v8.18.0

@@ -12,7 +12,7 @@
TestCase::class,
)->in(__DIR__);

expect()->extend('toBeExecutable', function (Closure $migration = null, array $options = []): Expectation {
expect()->extend('toBeExecutable', function (?Closure $migration = null, array $options = []): Expectation {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pint change due to: laravel/pint#236 ~3w ago

@tpetry
Copy link
Owner

tpetry commented Dec 24, 2023

Is there a specific reason why you bumped the dependencies? Composer will automatically load the newest matching ones. And you don‘t even use new features they provide.

@MohannadNaj
Copy link
Contributor Author

Is there a specific reason why you bumped the dependencies? Composer will automatically load the newest matching ones. And you don‘t even use new features they provide.

Bumped the major versions -which won't be picked up by composer automatically- in a pursuit to fix the PHP 8.3 errors while running ./vendor/bin/testbench package:discover.. Future CI builds will result in this error:

image

Walked through the Pest upgrade docs but didn't have to apply any additional changes. Did I miss something?.. Not sure what you meant by using the new features they provide, the testbench error described above was the sole motivation for these bumps -Except for using the new Larastan package name since it's now marked in packagist as abandoned-.

@tpetry
Copy link
Owner

tpetry commented Dec 28, 2023

Ah sorry, didn't read the first message clearly enough to see that its fixing PHP 8.3 issues.

@tpetry tpetry merged commit 52cba37 into tpetry:main Dec 28, 2023
121 of 122 checks passed
@MohannadNaj MohannadNaj deleted the composer branch January 6, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants