Week 7 #24
Open
Week 7 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the commit.
Added Week 7 Items
Causality-C
reviewed
Dec 18, 2022
|
|
||
|
|
||
| // Verifies password | ||
| app.post("/login", async (req, res) => { |
There was a problem hiding this comment.
Put these login / register functions in the auth.js and put that under routes
Causality-C
reviewed
Dec 18, 2022
|
|
||
| // Define route and middlewares | ||
| const users = express.Router(); | ||
| users.use(cors()); |
There was a problem hiding this comment.
Could you keep the todo routes in the todo.js file? I think you moved them so you could protect the route via authMiddleware, but you can export the authMiddleware in auth.js and import the auth middleware function here, then apply the middleware to the specified functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.