Detect py38 as python3.8

[asottile]

Resolves #912 CC @ericwb

I wonder if we can't just remove this list and parse the names instead 🤔

[codecov]

Codecov Report

Merging #913 into master will decrease coverage by 1.41%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #913      +/-   ##
==========================================
- Coverage    92.6%   91.19%   -1.42%     
==========================================
  Files          12       12              
  Lines        2327     2327              
  Branches      408      408              
==========================================
- Hits         2155     2122      -33     
- Misses        109      140      +31     
- Partials       63       65       +2

Impacted Files	Coverage Δ
src/tox/constants.py	100% <100%> (ø)	⬆️
src/tox/interpreters.py	69.84% <0%> (-19.05%)	⬇️
src/tox/venv.py	91.66% <0%> (-1.2%)	⬇️
src/tox/_pytestplugin.py	91.51% <0%> (-0.45%)	⬇️
src/tox/session.py	91.22% <0%> (-0.36%)	⬇️
src/tox/config.py	95.65% <0%> (-0.25%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf1ca1...773acc8. Read the comment docs.

[asottile]

ugh, because we've been ignoring (broken) VSTS it looks like linting has regressed:

2018-07-16T15:21:10.9696361Z diff --git a/src/tox/config.py b/src/tox/config.py
2018-07-16T15:21:10.9711357Z index f136185..fd94880 100755
2018-07-16T15:21:10.9725324Z --- a/src/tox/config.py
2018-07-16T15:21:10.9740306Z +++ b/src/tox/config.py
2018-07-16T15:21:10.9756257Z @@ -1219,7 +1219,7 @@ class SectionReader:
2018-07-16T15:21:10.9770692Z          else:
2018-07-16T15:21:10.9783636Z              x = self._apply_factors(x)
2018-07-16T15:21:10.9796359Z  
2018-07-16T15:21:10.9809777Z -        if replace and x and hasattr(x, 'replace'):
2018-07-16T15:21:10.9823883Z +        if replace and x and hasattr(x, "replace"):
2018-07-16T15:21:10.9837106Z              x = self._replace(x, name=name, crossonly=crossonly)
2018-07-16T15:21:10.9851022Z          # print "getstring", self.section_name, name, "returned", repr(x)
2018-07-16T15:21:10.9864721Z          return x
2018-07-16T15:21:10.9878373Z diff --git a/tests/test_config.py b/tests/test_config.py
2018-07-16T15:21:10.9891595Z index bfaa7f4..496c4a3 100644
2018-07-16T15:21:10.9904896Z --- a/tests/test_config.py
2018-07-16T15:21:10.9919701Z +++ b/tests/test_config.py
2018-07-16T15:21:10.9933199Z @@ -1440,7 +1440,7 @@ class TestConfigTestEnv:
2018-07-16T15:21:10.9947948Z          )
2018-07-16T15:21:10.9961303Z          conf = newconfig([], inisource).envconfigs["py27"]
2018-07-16T15:21:10.9975038Z          packages = [dep.name for dep in conf.deps]
2018-07-16T15:21:10.9990541Z -        assert packages == list(deps) + ['fun', 'frob>1.0,<2.0']
2018-07-16T15:21:11.0009271Z +        assert packages == list(deps) + ["fun", "frob>1.0,<2.0"]
2018-07-16T15:21:11.0024655Z          # assert packages == ["pytest", "pytest-cov", "fun", "frob>1.0,<2.0"]
2018-07-16T15:21:11.0040284Z  
2018-07-16T15:21:11.0054628Z      # https://github.com/tox-dev/tox/issues/706

@gaborbernat can we turn appveyor back on until vsts is functional?

[ericwb]

Can you also change doc/example/basic.rst and add py38 to the list of default test environments?

[gaborbernat]

will fix vsts in the morning 👌

[gaborbernat]

yeah add it into the documentation too 👌 otherwise it's ok, I would also approve an accept all 3x formats.

[webknjaz]

@asottile how about pypy36-7.0.0?

[gaborbernat]

we should add a PR for that

[webknjaz]

@gaborbernat I'm just not sure whether it should touch anything else than docs. So I'm leaving this to you.

[asottile]

this PR was superseded by #914 which auto detects versions and no longer hardcodes

[webknjaz]

Nice, is it possible to generate docs from that?

[asottile]

I'm not sure what you mean, tox doesn't have a static list of binaries it tries any more, even py49 will try and run python4.9

[webknjaz]

@asottile I mean I saw a list of supported envs hardcoded in docs. I thought it should be dealt with...

[webknjaz]

Here https://tox.readthedocs.io/en/latest/example/basic.html#a-simple-tox-ini-default-environments

Basic usage — tox 3.7.1.dev25 documentation

[asottile]

Ah, feel free to make a PR which kills that since we don't hardcode any more