Fix issue #727 #734
Merged
Fix issue #727 #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with ``IOError: [Errno 0] Error`` on Windows, this was fixed by using a simpler method to update the read buffers.
fschulze
force-pushed
the
727-fix-windows-tell-error-0
branch
from
af93779
to
e608604
Compare
Codecov Report
@@ Coverage Diff @@
## master #734 +/- ##
==========================================
- Coverage 94.66% 94.65% -0.01%
==========================================
Files 11 11
Lines 2379 2378 -1
==========================================
- Hits 2252 2251 -1
Misses 127 127
Continue to review full report at Codecov.
|
This was referenced Jan 9, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reading of command output sometimes failed with
IOError: [Errno 0] Erroron Windows, this was fixed by using a simpler method to update the read buffers.