#595 fix by updating implementation of #515 #598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way #515 was implemented did not play nicely with env var substitution. This might render the former additions completely or partially obsolete but I did not check this yet. First let's fix that bug.
|
Hi @AndreLouisCaron, could you also have a look at this? |
obestwalter
commented
Sep 2, 2017
| @@ -791,9 +791,8 @@ def __init__(self, config, inipath): | |||
| section = testenvprefix + name | |||
| factors = set(name.split('-')) | |||
| if section in self._cfg or factors <= known_factors: | |||
| config.envconfigs[name] = \ | |||
| self.make_envconfig(name, section, reader._subs, config, | |||
| replace=name in config.envlist) | |||
There was a problem hiding this comment.
This list only contains the envs in envlist and would mean that only testenvs get substituted that are defined in envlist. This is why we always replace at this early stage (configuration parsing) and don't crash if something is missing in a testenv. When an actual testrun is started we can check if a testenv would be run that has missing substitutions.
(cherry picked from commit e902f04)
obestwalter
requested review from
The-Compiler
and removed request for
The-Compiler
|
This is not the right way to fix this. I will open another one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #595
The way #515 was implemented did not play nicely with env var substitution. This might render the former additions completely or partially obsolete but I did not check this yet. First let's fix that bug.