Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose type checking dependencies into an extra #3404

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Expose type checking dependencies into an extra #3404

merged 1 commit into from
Oct 15, 2024

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Oct 14, 2024

This will allow to add tox to mypy_primer so new versions of mypy will be tested against it (used directly from their GHA pipelines). It should also make it easier to do type checking for plugin developers.

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@gaborbernat
Copy link
Member

mypre_primer ?

This will allow to add tox to mypre_primer so new versions of mypy
will be tested against it. It should also make it easier to
do type checking for plugin developers.
@ssbarnea
Copy link
Member Author

mypre_primer ?

Fixed the typo and included links to both primer project and also how it is used by mypy itself. I will be adding a PR to the project to add tox to it.

@ssbarnea ssbarnea marked this pull request as ready for review October 15, 2024 11:19
@ssbarnea ssbarnea requested a review from gaborbernat as a code owner October 15, 2024 11:19
@gaborbernat gaborbernat merged commit f919d0d into main Oct 15, 2024
28 checks passed
@gaborbernat gaborbernat deleted the fix/type branch October 15, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants