Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify an environment in the release workflow #2995

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

webknjaz
Copy link
Contributor

$sbj

@webknjaz webknjaz requested a review from gaborbernat as a code owner April 26, 2023 03:49
@@ -6,6 +6,9 @@ on:
jobs:
release:
runs-on: ubuntu-22.04
environment:
name: release
url: https://pypi.org/p/tox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain this line? Why we need it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will show up in UI, also you can apply protections in the repo settings, once it appears. I used to scope secrets to environments, instead of global settings. You can also require human approvals. All's optional.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's optional but is required when you fill out the field on the PyPI side.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't want the url: line, you can also just have environment: release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, but I'll need to create my own PR tomorrow because it doesn't let me merge this. Apparently you don't have the necessary rights to make this change. Or so GitHub says. ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, are you using the GitHub (mobile?) app? That thing has a limited token IIRC — using a web UI should help in such a case.

@gaborbernat gaborbernat merged commit 39b2bc4 into tox-dev:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants