-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override toxworkdir with --workdir. #2776
Conversation
tests/config/test_sets.py
Outdated
def test_config_work_dir(tox_project: ToxProjectCreator) -> None: | ||
project = tox_project({"tox.ini": "[tox]\ntoxworkdir=/tmp/foo"}) | ||
work_dir_flag = "a" | ||
result = project.run("c", "-k", "toxworkdir", "--core", "--workdir", work_dir_flag) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the primary key for this instead?
how? |
@gaborbernat should work_dir end with .tox? |
Only by default, if the user sets a dir we should use that. |
This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [tox](https://togithub.com/tox-dev/tox) | dev | patch | `4.0.16` -> `4.0.17` | `4.2.6` (+12) | --- ### Release Notes <details> <summary>tox-dev/tox</summary> ### [`v4.0.17`](https://togithub.com/tox-dev/tox/releases/tag/4.0.17) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.0.16...4.0.17) #### What's Changed - Suppress a report output when verbosity = 0. by [@​q0w](https://togithub.com/q0w) in [https://github.com/tox-dev/tox/pull/2774](https://togithub.com/tox-dev/tox/pull/2774) - Fix --sdistonly behaviour by [@​q0w](https://togithub.com/q0w) in [https://github.com/tox-dev/tox/pull/2775](https://togithub.com/tox-dev/tox/pull/2775) - Override toxworkdir with --workdir. by [@​q0w](https://togithub.com/q0w) in [https://github.com/tox-dev/tox/pull/2776](https://togithub.com/tox-dev/tox/pull/2776) #### New Contributors - [@​q0w](https://togithub.com/q0w) made their first contribution in [https://github.com/tox-dev/tox/pull/2774](https://togithub.com/tox-dev/tox/pull/2774) **Full Changelog**: tox-dev/tox@4.0.16...4.0.17 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43NC4wIiwidXBkYXRlZEluVmVyIjoiMzQuNzQuMCJ9--> Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
I'm not sure how yet but bf87bea reliably breaks our pyscaffoldext-custom-extension using Jenkins on Windows (python 3.8). I bisected
|
This reverts commit bf87bea.
Thanks for contribution
Closes #2654
Please, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix
)docs/changelog
folder