WIP: Honor workdir #2725
Closed
WIP: Honor workdir #2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
reviewed
Dec 15, 2022
| @@ -45,6 +45,7 @@ def _cmd(value: int) -> str: | |||
|
|
|||
|
|
|||
| @pytest.mark.integration() | |||
| @pytest.mark.xfail(reason="#2720") | |||
There was a problem hiding this comment.
I've already rejected this, please remove.
There was a problem hiding this comment.
It's the same commit. I'm currently developing on top of that other PR because without this marker, the tests fail on main and it's difficult to troubleshoot the problem when there are tests failing for other reasons. I'll plan to rebase off of this workaround commit once I have a fix worked out.
|
Seems stalled so we can reopen when we pick it up again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2654.
Thanks for contribution
Please, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix)docs/changelogfolder