fix replacement of sections with dash #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## rewrite #2000 +/- ##
===========================================
+ Coverage 99.83% 99.84% +0.01%
===========================================
Files 147 147
Lines 8276 8528 +252
Branches 823 919 +96
===========================================
+ Hits 8262 8515 +253
Misses 3 3
+ Partials 11 10 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gaborbernat
requested changes
Apr 6, 2021
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "envname, exp", |
There was a problem hiding this comment.
env_name and type annotate the arguments; in the rewrite we've dropped non snake case naming
There was a problem hiding this comment.
Also do add a changelog entry 👍🏻 thanks!
closes #1985 - also accepting a dash as a part of statically defined environment names Co-authored-by: Jürgen Gmach <juergen.gmach@googlemail.com> Co-authored-by: Miroslav Šedivý <eumiro@gmail.com>
Co-authored-by: Jürgen Gmach <juergen.gmach@googlemail.com> Co-authored-by: Miroslav Šedivý <eumiro@gmail.com>
Co-authored-by: Jürgen Gmach <juergen.gmach@googlemail.com> Co-authored-by: Miroslav Šedivý <eumiro@gmail.com>
This was
linked to
issues
Apr 6, 2021
gaborbernat
reviewed
Apr 6, 2021
Co-authored-by: Jürgen Gmach <juergen.gmach@googlemail.com> Co-authored-by: Miroslav Šedivý <eumiro@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1985 - also accepting a dash as a part of statically defined environment names
Co-authored-by: Jürgen Gmach juergen.gmach@googlemail.com
Co-authored-by: Miroslav Šedivý eumiro@gmail.com