Support environment files and comments in setenv #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
|
Released via https://pypi.org/project/tox/3.20.0/ |
webknjaz
reviewed
Sep 2, 2020
|
|
||
| Support for comments. Lines starting with ``#`` are ignored. | ||
|
|
||
| Support for environment files. Lines starting with the ``file|`` contain path to a environment |
There was a problem hiding this comment.
@gaborbernat any specific reason you implemented it with a prefix vs a substitution? If I were to design this, I'd probably go for {dotenv:file_path} there... I'm not judging, it just seems untypical for tox's UX.
There was a problem hiding this comment.
Didn't want to worry about conflicts with conditional factors 🤷♂️
There was a problem hiding this comment.
And it's not really substitution at all happening here, but different load mechanism. Substitution implies we just string replace that expression with content of the file, but actually here we never do that. Conceptually.
ssbarnea
pushed a commit
to ssbarnea/tox
that referenced
this pull request
Apr 19, 2021
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1667.