Passenv PIP_EXTRA_INDEX_URL by default #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgealton
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
gaborbernat
approved these changes
Apr 21, 2020
gaborbernat
approved these changes
Apr 21, 2020
|
Is there any reason why we would not want to whitelist |
ssbarnea
pushed a commit
to ssbarnea/tox
that referenced
this pull request
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request passes the
PIP_EXTRA_INDEX_URLenvironment variable to tox environments by default. Allowing pip index configuration to pass to tox environments without having to setpassenvconfiguration.I believe this is in spirit with the current
PIP_INDEX_URLdefault passing behaviour.This closes #1561