fix colouring on windows #1471
Merged
fix colouring on windows #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eine
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
gaborbernat
reviewed
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1468
Currently,
coloramais required in order to get coloured output on Windows, even if it is not used. This is because of:https://github.com/pytest-dev/py/blob/1e99d20f31ef511fc2f1a9e49ba970acad441d4e/py/_io/terminalwriter.py#L16-L24
Since neither tox nor TerminalWriter do install colorama explicitly, it falls back to
win32_and_ctypes, which does not work. In this PR, colorama is added toinstall_requires, for it to be installed on Windows only.At first, I was not convinced about adding the dependency, because it is not required for minimal usage of tox (i.e., without colours). However, I saw that it will be included for all platforms in #1400, so I guess that it is acceptable.