Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass through ProgramFiles* and ProgramData by default #2382

Closed
jaraco opened this issue Mar 19, 2022 · 4 comments · Fixed by #2383
Closed

Pass through ProgramFiles* and ProgramData by default #2382

jaraco opened this issue Mar 19, 2022 · 4 comments · Fixed by #2383
Labels
feature:new something does not exist yet, but should

Comments

@jaraco
Copy link

jaraco commented Mar 19, 2022

I'd like to follow up on #1673. I couldn't comment or even +1 that issue.

I believe the characterization of the issue as setuptools-specific was incorrect.

Although the issue does affect Setuptools and not Flit, that's only because Setuptools supports building C extensions on Windows.

The issue can't be fixed in Setuptools. By the time tox has masked the ProgramFiles env var, Setuptools has little hope of recovering that setting.

We're not asking tox to patch Setuptools. Instead, we're asking tox to consider honoring the system's intrinsic environment configuration by passing through system-level variables, variables that would be unlikely to be configured by the user and which are necessary for basic operation on the platform (similar to PATH, SYSTEMDRIVE, and SYSTEMROOT).

Failing to support this model will instead require every project that builds extension modules on Windows to bypass this setting in their tox config. I believe this issue was largely missed until recently because most users were still testing on older platforms/compilers that did not rely on vswhere for discovery, but now that Windows 2022 is the default in Github, it's affecting a wide array of users. I contend:

  • this exemption is required in every case it affects
  • there is no known case that this masking is currently important
  • the number of affected projects is large.

I can put together a repro that doesn't involve Setuptools if that helps persuade.
@jaraco jaraco added the feature:new something does not exist yet, but should label Mar 19, 2022
@jaraco jaraco changed the title Pass through ProgramFiles* by default Pass through ProgramFiles* and ProgramData by default Mar 19, 2022
@jaraco
Copy link
Author

jaraco commented Mar 19, 2022

In pypa/distutils#118 (comment), we also observed that ProgramData needs to be passed through for vswhere to operate correctly, so it should be included also.

@jaraco jaraco mentioned this issue Mar 19, 2022
Closed
abravalheri added a commit to pypa/setuptools that referenced this issue Mar 20, 2022
@abravalheri
[CI] Add workaround for problems with windows-latest host (#3174)
8723db4 
Add workaround for workaround for tox-dev/tox#2382
@gaborbernat
Copy link
Member

Feel free to put in a PR for this 👍

jaraco added a commit to jaraco/tox that referenced this issue Mar 21, 2022
@jaraco
Add PROGRAM* environment variables on windows to facilitate compiler …
af59de9 
…discovery. Fixes tox-dev#2382.
@jaraco jaraco mentioned this issue Mar 21, 2022
Merged
6 tasks
@mayeut mayeut mentioned this issue Apr 2, 2022
Closed
7 tasks
@pllim
Copy link

pllim commented Apr 4, 2022

Hello. Which tox release will have this fix and has it happened? If not, any plan to release this soon? Thanks!

@jugmac00
Copy link
Member

jugmac00 commented Apr 4, 2022

The fix has not been released yet.

Currently only @gaborbernat does releases.

In the meantime, you can certainly install tox directly from GitHub:

pip install git+https://github.com/tox-dev/tox.git#master

mergify bot pushed a commit to andrewbolster/bolster that referenced this issue Apr 11, 2022
@dependabot
Bump tox from 3.24.5 to 3.25.0 (#272)
14108ef 
Bumps [tox](https://github.com/tox-dev/tox) from 3.24.5 to 3.25.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/tox-dev/tox/blob/master/docs/changelog.rst">tox's changelog</a>.</em></p>
<blockquote>
<h2>v3.25.0 (2022-04-11)</h2>
<p>Bugfixes
^^^^^^^^</p>
<ul>
<li>Fixed failing isolated_build because setuptools warning was captured
in <code>build_requires</code>. -- by :user:<code>zariiii9003</code>
<code>[#2332](tox-dev/tox#2332) &lt;https://github.com/tox-dev/tox/issues/2332&gt;</code>_</li>
<li>Avoid potential 30s delay caused by socket.getfqdn(). -- by :user:<code>ssbarnea</code>
<code>[#2375](tox-dev/tox#2375) &lt;https://github.com/tox-dev/tox/issues/2375&gt;</code>_</li>
</ul>
<p>Features
^^^^^^^^</p>
<ul>
<li>Ignore missing commands if they are prefixed by <code>-</code>
-- by :user:<code>cdown</code>.
<code>[#2315](tox-dev/tox#2315) &lt;https://github.com/tox-dev/tox/issues/2315&gt;</code>_</li>
<li>Add default environment variables (such as http_proxy) regardless of their case to passenv on UNIX -- by :user:<code>poggenhans</code>.
<code>[#2372](tox-dev/tox#2372) &lt;https://github.com/tox-dev/tox/issues/2372&gt;</code>_</li>
<li>On Windows <code>PROGRAMFILES</code>, <code>PROGRAMFILES(X86)</code>, and <code>PROGRAMDATA</code> environment variables are now passed through, unmasking system values necessary to locate resources such as a C compiler.
<code>[#2382](tox-dev/tox#2382) &lt;https://github.com/tox-dev/tox/issues/2382&gt;</code>_</li>
</ul>
<p>Documentation
^^^^^^^^^^^^^</p>
<ul>
<li>Deleted the tox mailing list -- by :user:<code>jugmac00</code>
<code>[#2364](tox-dev/tox#2364) &lt;https://github.com/tox-dev/tox/issues/2364&gt;</code>_</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/tox-dev/tox/commit/cd33742da5ff3e4e2153d6df48c6e23ed5744bdc"><code>cd33742</code></a> release 3.25.0</li>
<li><a href="https://github.com/tox-dev/tox/commit/cafb36143449d19e93811d539565e6fcfc2cc13e"><code>cafb361</code></a> doc: fix typo in description of tox-conda plugin (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2363">#2363</a>)</li>
<li><a href="https://github.com/tox-dev/tox/commit/c32b828b798c04ca7ac42c8a39ec93955a09e0f7"><code>c32b828</code></a> [pre-commit.ci] pre-commit autoupdate</li>
<li><a href="https://github.com/tox-dev/tox/commit/00a969595d66c214467afc77cae26c6334f1ddbf"><code>00a9695</code></a> Add PROGRAM environment variables on Windows (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2383">#2383</a>)</li>
<li><a href="https://github.com/tox-dev/tox/commit/eb1bd33d152f11f521805fe17e2240fb768e05d9"><code>eb1bd33</code></a> Use gethostname instead of potentially slow getfqdn (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2380">#2380</a>)</li>
<li><a href="https://github.com/tox-dev/tox/commit/91bbd7f0d5f31843679a26ff0738806149f07182"><code>91bbd7f</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2343">#2343</a>)</li>
<li><a href="https://github.com/tox-dev/tox/commit/31dc5b1e1046c0166a9739784ab83e7b843b42fe"><code>31dc5b1</code></a> Passenv: Include default env variables regardless of their case on UNIX (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2378">#2378</a>)</li>
<li><a href="https://github.com/tox-dev/tox/commit/465cb9817cadea74dbddc7667c008dc784318c8a"><code>465cb98</code></a> [pre-commit.ci] auto fixes from pre-commit.com hooks</li>
<li><a href="https://github.com/tox-dev/tox/commit/587e625d880cf5280625c2e38916aa56866292c7"><code>587e625</code></a> Delete <code>tox</code> mailing list</li>
<li><a href="https://github.com/tox-dev/tox/commit/a03c51884d63f5e9e08bdb7083cda29061fda098"><code>a03c518</code></a> Fix the CI</li>
<li>Additional commits viewable in <a href="https://github.com/tox-dev/tox/compare/3.24.5...3.25.0">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=tox&package-manager=pip&previous-version=3.24.5&new-version=3.25.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
bors bot added a commit to meilisearch/meilisearch-python that referenced this issue Apr 22, 2022
@bors @dependabot @alallema
Merge #441
a69e0a2 
441: Bump tox from 3.24.5 to 3.25.0 r=alallema a=dependabot[bot]

Bumps [tox](https://github.com/tox-dev/tox) from 3.24.5 to 3.25.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/tox-dev/tox/blob/master/docs/changelog.rst">tox's changelog</a>.</em></p>
<blockquote>
<h2>v3.25.0 (2022-04-11)</h2>
<p>Bugfixes
^^^^^^^^</p>
<ul>
<li>Fixed failing isolated_build because setuptools warning was captured
in <code>build_requires</code>. -- by :user:<code>zariiii9003</code>
<code>[#2332](tox-dev/tox#2332) &lt;https://github.com/tox-dev/tox/issues/2332&gt;</code>_</li>
<li>Avoid potential 30s delay caused by socket.getfqdn(). -- by :user:<code>ssbarnea</code>
<code>[#2375](tox-dev/tox#2375) &lt;https://github.com/tox-dev/tox/issues/2375&gt;</code>_</li>
</ul>
<p>Features
^^^^^^^^</p>
<ul>
<li>Ignore missing commands if they are prefixed by <code>-</code>
-- by :user:<code>cdown</code>.
<code>[#2315](tox-dev/tox#2315) &lt;https://github.com/tox-dev/tox/issues/2315&gt;</code>_</li>
<li>Add default environment variables (such as http_proxy) regardless of their case to passenv on UNIX -- by :user:<code>poggenhans</code>.
<code>[#2372](tox-dev/tox#2372) &lt;https://github.com/tox-dev/tox/issues/2372&gt;</code>_</li>
<li>On Windows <code>PROGRAMFILES</code>, <code>PROGRAMFILES(X86)</code>, and <code>PROGRAMDATA</code> environment variables are now passed through, unmasking system values necessary to locate resources such as a C compiler.
<code>[#2382](tox-dev/tox#2382) &lt;https://github.com/tox-dev/tox/issues/2382&gt;</code>_</li>
</ul>
<p>Documentation
^^^^^^^^^^^^^</p>
<ul>
<li>Deleted the tox mailing list -- by :user:<code>jugmac00</code>
<code>[#2364](tox-dev/tox#2364) &lt;https://github.com/tox-dev/tox/issues/2364&gt;</code>_</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/tox-dev/tox/commit/cd33742da5ff3e4e2153d6df48c6e23ed5744bdc"><code>cd33742</code></a> release 3.25.0</li>
<li><a href="https://github.com/tox-dev/tox/commit/cafb36143449d19e93811d539565e6fcfc2cc13e"><code>cafb361</code></a> doc: fix typo in description of tox-conda plugin (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2363">#2363</a>)</li>
<li><a href="https://github.com/tox-dev/tox/commit/c32b828b798c04ca7ac42c8a39ec93955a09e0f7"><code>c32b828</code></a> [pre-commit.ci] pre-commit autoupdate</li>
<li><a href="https://github.com/tox-dev/tox/commit/00a969595d66c214467afc77cae26c6334f1ddbf"><code>00a9695</code></a> Add PROGRAM environment variables on Windows (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2383">#2383</a>)</li>
<li><a href="https://github.com/tox-dev/tox/commit/eb1bd33d152f11f521805fe17e2240fb768e05d9"><code>eb1bd33</code></a> Use gethostname instead of potentially slow getfqdn (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2380">#2380</a>)</li>
<li><a href="https://github.com/tox-dev/tox/commit/91bbd7f0d5f31843679a26ff0738806149f07182"><code>91bbd7f</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2343">#2343</a>)</li>
<li><a href="https://github.com/tox-dev/tox/commit/31dc5b1e1046c0166a9739784ab83e7b843b42fe"><code>31dc5b1</code></a> Passenv: Include default env variables regardless of their case on UNIX (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2378">#2378</a>)</li>
<li><a href="https://github.com/tox-dev/tox/commit/465cb9817cadea74dbddc7667c008dc784318c8a"><code>465cb98</code></a> [pre-commit.ci] auto fixes from pre-commit.com hooks</li>
<li><a href="https://github.com/tox-dev/tox/commit/587e625d880cf5280625c2e38916aa56866292c7"><code>587e625</code></a> Delete <code>tox</code> mailing list</li>
<li><a href="https://github.com/tox-dev/tox/commit/a03c51884d63f5e9e08bdb7083cda29061fda098"><code>a03c518</code></a> Fix the CI</li>
<li>Additional commits viewable in <a href="https://github.com/tox-dev/tox/compare/3.24.5...3.25.0">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=tox&package-manager=pip&previous-version=3.24.5&new-version=3.25.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

You can trigger a rebase of this PR by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
meili-bors bot added a commit to meilisearch/docs-scraper that referenced this issue May 16, 2022
@meili-bors @dependabot
Merge #210
54ab95a 
210: Bump tox from 3.24.5 to 3.25.0 r=bidoubiwa a=dependabot[bot]

Bumps [tox](https://github.com/tox-dev/tox) from 3.24.5 to 3.25.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/tox-dev/tox/blob/master/docs/changelog.rst">tox's changelog</a>.</em></p>
<blockquote>
<h2>v3.25.0 (2022-04-11)</h2>
<p>Bugfixes
^^^^^^^^</p>
<ul>
<li>Fixed failing isolated_build because setuptools warning was captured
in <code>build_requires</code>. -- by :user:<code>zariiii9003</code>
<code>[#2332](tox-dev/tox#2332) &lt;https://github.com/tox-dev/tox/issues/2332&gt;</code>_</li>
<li>Avoid potential 30s delay caused by socket.getfqdn(). -- by :user:<code>ssbarnea</code>
<code>[#2375](tox-dev/tox#2375) &lt;https://github.com/tox-dev/tox/issues/2375&gt;</code>_</li>
</ul>
<p>Features
^^^^^^^^</p>
<ul>
<li>Ignore missing commands if they are prefixed by <code>-</code>
-- by :user:<code>cdown</code>.
<code>[#2315](tox-dev/tox#2315) &lt;https://github.com/tox-dev/tox/issues/2315&gt;</code>_</li>
<li>Add default environment variables (such as http_proxy) regardless of their case to passenv on UNIX -- by :user:<code>poggenhans</code>.
<code>[#2372](tox-dev/tox#2372) &lt;https://github.com/tox-dev/tox/issues/2372&gt;</code>_</li>
<li>On Windows <code>PROGRAMFILES</code>, <code>PROGRAMFILES(X86)</code>, and <code>PROGRAMDATA</code> environment variables are now passed through, unmasking system values necessary to locate resources such as a C compiler.
<code>[#2382](tox-dev/tox#2382) &lt;https://github.com/tox-dev/tox/issues/2382&gt;</code>_</li>
</ul>
<p>Documentation
^^^^^^^^^^^^^</p>
<ul>
<li>Deleted the tox mailing list -- by :user:<code>jugmac00</code>
<code>[#2364](tox-dev/tox#2364) &lt;https://github.com/tox-dev/tox/issues/2364&gt;</code>_</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/tox-dev/tox/commit/cd33742da5ff3e4e2153d6df48c6e23ed5744bdc"><code>cd33742</code></a> release 3.25.0</li>
<li><a href="https://github.com/tox-dev/tox/commit/cafb36143449d19e93811d539565e6fcfc2cc13e"><code>cafb361</code></a> doc: fix typo in description of tox-conda plugin (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2363">#2363</a>)</li>
<li><a href="https://github.com/tox-dev/tox/commit/c32b828b798c04ca7ac42c8a39ec93955a09e0f7"><code>c32b828</code></a> [pre-commit.ci] pre-commit autoupdate</li>
<li><a href="https://github.com/tox-dev/tox/commit/00a969595d66c214467afc77cae26c6334f1ddbf"><code>00a9695</code></a> Add PROGRAM environment variables on Windows (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2383">#2383</a>)</li>
<li><a href="https://github.com/tox-dev/tox/commit/eb1bd33d152f11f521805fe17e2240fb768e05d9"><code>eb1bd33</code></a> Use gethostname instead of potentially slow getfqdn (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2380">#2380</a>)</li>
<li><a href="https://github.com/tox-dev/tox/commit/91bbd7f0d5f31843679a26ff0738806149f07182"><code>91bbd7f</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2343">#2343</a>)</li>
<li><a href="https://github.com/tox-dev/tox/commit/31dc5b1e1046c0166a9739784ab83e7b843b42fe"><code>31dc5b1</code></a> Passenv: Include default env variables regardless of their case on UNIX (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2378">#2378</a>)</li>
<li><a href="https://github.com/tox-dev/tox/commit/465cb9817cadea74dbddc7667c008dc784318c8a"><code>465cb98</code></a> [pre-commit.ci] auto fixes from pre-commit.com hooks</li>
<li><a href="https://github.com/tox-dev/tox/commit/587e625d880cf5280625c2e38916aa56866292c7"><code>587e625</code></a> Delete <code>tox</code> mailing list</li>
<li><a href="https://github.com/tox-dev/tox/commit/a03c51884d63f5e9e08bdb7083cda29061fda098"><code>a03c518</code></a> Fix the CI</li>
<li>Additional commits viewable in <a href="https://github.com/tox-dev/tox/compare/3.24.5...3.25.0">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=tox&package-manager=pip&previous-version=3.24.5&new-version=3.25.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

You can trigger a rebase of this PR by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
meili-bors bot added a commit to meilisearch/docs-scraper that referenced this issue May 16, 2022
@meili-bors @dependabot
Merge #210
05aef08 
210: Bump tox from 3.24.5 to 3.25.0 r=bidoubiwa a=dependabot[bot]

Bumps [tox](https://github.com/tox-dev/tox) from 3.24.5 to 3.25.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/tox-dev/tox/blob/master/docs/changelog.rst">tox's changelog</a>.</em></p>
<blockquote>
<h2>v3.25.0 (2022-04-11)</h2>
<p>Bugfixes
^^^^^^^^</p>
<ul>
<li>Fixed failing isolated_build because setuptools warning was captured
in <code>build_requires</code>. -- by :user:<code>zariiii9003</code>
<code>[#2332](tox-dev/tox#2332) &lt;https://github.com/tox-dev/tox/issues/2332&gt;</code>_</li>
<li>Avoid potential 30s delay caused by socket.getfqdn(). -- by :user:<code>ssbarnea</code>
<code>[#2375](tox-dev/tox#2375) &lt;https://github.com/tox-dev/tox/issues/2375&gt;</code>_</li>
</ul>
<p>Features
^^^^^^^^</p>
<ul>
<li>Ignore missing commands if they are prefixed by <code>-</code>
-- by :user:<code>cdown</code>.
<code>[#2315](tox-dev/tox#2315) &lt;https://github.com/tox-dev/tox/issues/2315&gt;</code>_</li>
<li>Add default environment variables (such as http_proxy) regardless of their case to passenv on UNIX -- by :user:<code>poggenhans</code>.
<code>[#2372](tox-dev/tox#2372) &lt;https://github.com/tox-dev/tox/issues/2372&gt;</code>_</li>
<li>On Windows <code>PROGRAMFILES</code>, <code>PROGRAMFILES(X86)</code>, and <code>PROGRAMDATA</code> environment variables are now passed through, unmasking system values necessary to locate resources such as a C compiler.
<code>[#2382](tox-dev/tox#2382) &lt;https://github.com/tox-dev/tox/issues/2382&gt;</code>_</li>
</ul>
<p>Documentation
^^^^^^^^^^^^^</p>
<ul>
<li>Deleted the tox mailing list -- by :user:<code>jugmac00</code>
<code>[#2364](tox-dev/tox#2364) &lt;https://github.com/tox-dev/tox/issues/2364&gt;</code>_</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/tox-dev/tox/commit/cd33742da5ff3e4e2153d6df48c6e23ed5744bdc"><code>cd33742</code></a> release 3.25.0</li>
<li><a href="https://github.com/tox-dev/tox/commit/cafb36143449d19e93811d539565e6fcfc2cc13e"><code>cafb361</code></a> doc: fix typo in description of tox-conda plugin (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2363">#2363</a>)</li>
<li><a href="https://github.com/tox-dev/tox/commit/c32b828b798c04ca7ac42c8a39ec93955a09e0f7"><code>c32b828</code></a> [pre-commit.ci] pre-commit autoupdate</li>
<li><a href="https://github.com/tox-dev/tox/commit/00a969595d66c214467afc77cae26c6334f1ddbf"><code>00a9695</code></a> Add PROGRAM environment variables on Windows (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2383">#2383</a>)</li>
<li><a href="https://github.com/tox-dev/tox/commit/eb1bd33d152f11f521805fe17e2240fb768e05d9"><code>eb1bd33</code></a> Use gethostname instead of potentially slow getfqdn (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2380">#2380</a>)</li>
<li><a href="https://github.com/tox-dev/tox/commit/91bbd7f0d5f31843679a26ff0738806149f07182"><code>91bbd7f</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2343">#2343</a>)</li>
<li><a href="https://github.com/tox-dev/tox/commit/31dc5b1e1046c0166a9739784ab83e7b843b42fe"><code>31dc5b1</code></a> Passenv: Include default env variables regardless of their case on UNIX (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2378">#2378</a>)</li>
<li><a href="https://github.com/tox-dev/tox/commit/465cb9817cadea74dbddc7667c008dc784318c8a"><code>465cb98</code></a> [pre-commit.ci] auto fixes from pre-commit.com hooks</li>
<li><a href="https://github.com/tox-dev/tox/commit/587e625d880cf5280625c2e38916aa56866292c7"><code>587e625</code></a> Delete <code>tox</code> mailing list</li>
<li><a href="https://github.com/tox-dev/tox/commit/a03c51884d63f5e9e08bdb7083cda29061fda098"><code>a03c518</code></a> Fix the CI</li>
<li>Additional commits viewable in <a href="https://github.com/tox-dev/tox/compare/3.24.5...3.25.0">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=tox&package-manager=pip&previous-version=3.24.5&new-version=3.25.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

You can trigger a rebase of this PR by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature:new something does not exist yet, but should
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add PROGRAM environment variables on Windows jaraco/tox
4 participants
@jaraco @gaborbernat @pllim @jugmac00