Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: consider offering alternative to whitelist_externals #1491

Closed
annevk opened this issue Jan 3, 2020 · 6 comments · Fixed by #1601
Closed

Editorial: consider offering alternative to whitelist_externals #1491

annevk opened this issue Jan 3, 2020 · 6 comments · Fixed by #1601
Labels
bug:normal affects many people or has quite an impact pr-merged

Comments

@annevk
Copy link

annevk commented Jan 3, 2020

Using whitelist (and its counterpart) isn't exactly welcoming. While migrating away from it entirely might be hard due to compatibility considerations, it'd be nice if configuration files from projects that build on this technology could avoid it.

See https://tools.ietf.org/html/draft-knodel-terminology for additional context.
@annevk annevk added the bug:normal affects many people or has quite an impact label Jan 3, 2020
@annevk annevk mentioned this issue Jan 3, 2020
Closed
@gaborbernat
Copy link
Member

We cannot do this without breaking backwards compatibility. We might be able to add other aliases for this setting as part of #1394, ETA at least September.

@kennknowles
Copy link

Can an alias be provided in the meantime?

@kennknowles kennknowles mentioned this issue Jun 10, 2020
Merged
4 tasks
@gaborbernat
Copy link
Member

Can an alias be provided in the meantime?

PRs are welcome.

@dajose dajose mentioned this issue Jun 16, 2020
Merged
@helpr helpr bot added the pr-available label Jun 16, 2020
kennknowles added a commit to kennknowles/beam that referenced this issue Jun 22, 2020
@kennknowles
Remove "whitelist" and "blacklist" terminology from repository where …
54c5703 
…possible

For context, see:

 - https://tools.ietf.org/html/draft-knodel-terminology-01
 - https://developers.google.com/style/inclusive-documentation#features-and-users

Blocked by configuration of other projects and vendored code:

 - tox-dev/tox#1491
 - jenkinsci/ghprb-plugin#784
 - Generated storage_v1_messages.py (undocumented how we generated this!?)
 - Many golang vendored modules
@helpr helpr bot added pr-merged and removed pr-available labels Jul 23, 2020
@annevk
Copy link
Author

annevk commented Jul 23, 2020

@dajose thank you!

@annevk annevk mentioned this issue Jul 23, 2020
Closed
@gaborbernat
Copy link
Member

thanks

@gaborbernat gaborbernat reopened this Jul 23, 2020
@gaborbernat
Copy link
Member

This is now released with 3.18.0

yirutang pushed a commit to yirutang/beam that referenced this issue Jul 23, 2020
@kennknowles @yirutang
Remove "whitelist" and "blacklist" terminology from repository where …
9c40c21 
…possible

For context, see:

 - https://tools.ietf.org/html/draft-knodel-terminology-01
 - https://developers.google.com/style/inclusive-documentation#features-and-users

Blocked by configuration of other projects and vendored code:

 - tox-dev/tox#1491
 - jenkinsci/ghprb-plugin#784
 - Generated storage_v1_messages.py (undocumented how we generated this!?)
 - Many golang vendored modules
@pkolbus pkolbus mentioned this issue Nov 29, 2020
Merged
3 tasks
@bittner bittner mentioned this issue Jan 7, 2021
Open
@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug:normal affects many people or has quite an impact pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add alias "allowlist_externals" to "whitelist_externals"
3 participants
@kennknowles @gaborbernat @annevk