More robust determination of rtype location / fix issue 302 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves 302. This increases the robustness of the handling of the docutils tree. The docutils rst parser seems to have a bunch of bugs / shortcomings. The original problem was that several list types do not get their line number set. So to find the line number of a node, if the node itself has None as the line number, we descend through the first children of the node until we find one with a non-None line number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #302.
This increases the robustness of the handling of the docutils tree. The docutils rst parser seems to have a bunch of bugs / shortcomings. The original problem was that several list types do not get their line number set. So to find the line number of a node, if the node itself has None as the line number, we descend through the first children of the node until we find one with a non-None line number.