Prevents reaching inner blocks that contains if TYPE_CHECKING
#211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thepabloaguilar
force-pushed
the
fix-type-guard-for-classes
branch
from
2f08dcd
to
8e6b7b2
Compare
gaborbernat
requested changes
Jan 18, 2022
thepabloaguilar
force-pushed
the
fix-type-guard-for-classes
branch
from
8e6b7b2
to
2af7193
Compare
thepabloaguilar
changed the title
if TYPE_CHECKING
gaborbernat
requested changes
Jan 18, 2022
gaborbernat
requested changes
Jan 18, 2022
gaborbernat
reviewed
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for your work on this plugin! We're having some problems with returns because we use type guards inside some classes like here which leads in some warnings while building sphinx broking our builds:
This PR fixes that issue, basically when a class object doesn't have the
__globals__attribute so we basically can callexecwithout the globals if the given object doesn't have the mentioned attribute.