Add Map service combinator
#435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
hawkw
reviewed
Apr 13, 2020
There was a problem hiding this comment.
What do you think about calling this map_request instead? I assumed map would behave more like Future::map, and mutate the response. It seems like we might want to have separate map_request and map_response combinators, so it could be good to disambiguate them.
Sorry for bikeshedding.
|
@hawkw I like that, will make the change and add the other one. 👍 |
jonhoo
added
A-util
|
This also closes #272 I believe? |
jonhoo
reviewed
Apr 14, 2020
jonhoo
approved these changes
Apr 14, 2020
|
Approving subject to @hawkw's request and the one comment I made about the test :) |
davidbarsky
reviewed
Apr 14, 2020
Co-Authored-By: David Barsky <me@davidbarsky.com>
jonhoo
reviewed
Apr 14, 2020
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
davidbarsky
requested changes
Apr 14, 2020
|
@davidbarsky they are both |
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
davidbarsky
requested changes
Apr 14, 2020
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
davidbarsky
requested changes
Apr 14, 2020
Co-Authored-By: David Barsky <me@davidbarsky.com>
Co-Authored-By: David Barsky <me@davidbarsky.com>
Co-Authored-By: David Barsky <me@davidbarsky.com>
davidbarsky
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lucio Franco luciofranco14@gmail.com