Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Early push to bring tracing into tower #298

Merged
merged 16 commits into from
Jul 12, 2019
Merged

Early push to bring tracing into tower #298

merged 16 commits into from
Jul 12, 2019

Conversation

jonhoo
Copy link
Collaborator

@jonhoo jonhoo commented Jul 5, 2019

No description provided.

hawkw
hawkw reviewed Jul 10, 2019
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start, I left some notes that you may find valuable.

tower-balance/Cargo.toml Outdated Show resolved Hide resolved
tower-balance/examples/demo.rs Outdated Show resolved Hide resolved
tower-buffer/src/service.rs Outdated Show resolved Hide resolved
tower-buffer/src/worker.rs Outdated Show resolved Hide resolved
tower-buffer/src/worker.rs Show resolved Hide resolved
@jonhoo jonhoo marked this pull request as ready for review July 11, 2019 01:49
@jonhoo
Copy link
Collaborator Author

jonhoo commented Jul 11, 2019

I don't think there's a strong reason not to land something like this soon, and then we can iterate on it going forward.

@hawkw
Copy link
Member

hawkw commented Jul 11, 2019

I would love to be using this in linkerd, fwiw.

@jonhoo jonhoo requested a review from hawkw July 12, 2019 00:22
hawkw
hawkw approved these changes Jul 12, 2019
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM and I'd be happy to see it merge as-is. I left some comments on how we could potentially make more idiomatic use of tracing by including more structured data in the events we record, feel free to take it or leave it.

tower-balance/src/p2c/service.rs Outdated Show resolved Hide resolved
tower-balance/src/p2c/service.rs Outdated Show resolved Hide resolved
tower-buffer/src/worker.rs Outdated Show resolved Hide resolved
tower-buffer/src/service.rs Show resolved Hide resolved
tower-buffer/src/worker.rs Outdated Show resolved Hide resolved
tower-buffer/src/worker.rs Outdated Show resolved Hide resolved
tower-balance/src/pool.rs Outdated Show resolved Hide resolved
tower-balance/src/pool.rs Outdated Show resolved Hide resolved
tower-balance/src/pool.rs Outdated Show resolved Hide resolved
tower-balance/src/pool.rs Show resolved Hide resolved
hawkw
hawkw approved these changes Jul 12, 2019
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM beyond that I think the service count is being reported incorrectly in tower_balance::pool. Fix that & this is good to merge!

tower-balance/src/p2c/service.rs Show resolved Hide resolved
tower-balance/src/pool.rs Show resolved Hide resolved
@jonhoo jonhoo merged commit 491dfbe into master Jul 12, 2019
@samscott89 samscott89 mentioned this pull request Jul 21, 2019
Closed
@seanmonstar seanmonstar deleted the jonhoo/tracing branch August 21, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonhoo @hawkw