Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS middleware should set the Vary header #198

Closed
davidpdrsn opened this issue Jan 1, 2022 · 0 comments · Fixed by #199
Closed

CORS middleware should set the Vary header #198

davidpdrsn opened this issue Jan 1, 2022 · 0 comments · Fixed by #199
Labels
C-bug Category: This is a bug.

Comments

@davidpdrsn
Copy link
Member

From reading https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Origin it sounds like we should be setting Vary in cors responses. Probably also for other headers than Access-Control-Allow-Origin.
@davidpdrsn davidpdrsn added the C-bug Category: This is a bug. label Jan 1, 2022
shepmaster added a commit to integer32llc/tower-http that referenced this issue Jan 1, 2022
@shepmaster
CORS middleware should set the Vary header
c9f042c 
The headers are based on [corsware][] which states:

> These are all headers which can influence the outcome of any given
> CORS request.

Closes tower-rs#198

[corsware]: https://github.com/atorstling/corsware/blob/3467805a74145b788f8234f9f994caf045509b31/src/lib.rs#L223-L229
shepmaster added a commit to integer32llc/tower-http that referenced this issue Jan 1, 2022
@shepmaster
CORS middleware should set the Vary header
7fac8ed 
The headers are based on [corsware][] which states:

> These are all headers which can influence the outcome of any given
> CORS request.

Fixes tower-rs#198

[corsware]: https://github.com/atorstling/corsware/blob/3467805a74145b788f8234f9f994caf045509b31/src/lib.rs#L223-L229
@shepmaster shepmaster mentioned this issue Jan 1, 2022
Merged
davidpdrsn pushed a commit that referenced this issue Jan 3, 2022
@shepmaster
Set Vary header in CORS middleware (#199)
981a477 
The headers are based on [corsware][] which states:

> These are all headers which can influence the outcome of any given
> CORS request.

Fixes #198

[corsware]: https://github.com/atorstling/corsware/blob/3467805a74145b788f8234f9f994caf045509b31/src/lib.rs#L223-L229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CORS middleware should set the Vary header integer32llc/tower-http
1 participant
@davidpdrsn