CI: trigger workflow on push again #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't trigger workflow on push, we will not build and push a new container image when a PR is merged. Because of this, the container image with the main tag is currently based on ESP-IDF v5.1, while we already have code in the main branch that requires ESP-IDF v5.2. We will also not publish a release anymore when pushing a tag. Trigger workflow on push again, but only for the main and release branches, and for any tag. Also add an empty newline to Dockerfile to make sure we trigger container build and push, so that the container image with the main tag will be based on ESP-IDF v5.2. Fixes: 390533f ("CI: don't trigger workflow on push")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't trigger workflow on push, we will not build and push a new container image when a PR is merged. Because of this, the container image with the main tag is currently based on ESP-IDF v5.1, while we already have code in the main branch that requires ESP-IDF v5.2.
Trigger workflow on push again, but only for the main and release branches.
Also add an empty newline to Dockerfile to make sure we trigger container build and push, so that the container image with the main tag will be based on ESP-IDF v5.2.
Fixes: 390533f ("CI: don't trigger workflow on push")