Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove padding and add full-header, full-footer to support footnote #27

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

OrangeX4
Copy link
Member

@OrangeX4 OrangeX4 commented Apr 4, 2024

(Original page layout ↑)

To support footnote, we need to modify the page layout of the slide from:

page(
  header: header,
  pad(
    body
  ),
  footer: footer,
)

to

set page(
  header: negative-pad(header),
  footer: negative-pad(footer),
)
body

structure.

Where let negative-pad = pad.with(x: -margin.x), which extends the header/footer to occupy the entire width of the page.

As a result, we remove the self.padding parameter and add self.full-header and self.full-footer to control whether this feature is enabled (not enabled for the simple theme, but enabled for all other themes).

This PR is a breaking change, but it enables support for footnote #26 and allows normal usage of set align(horizon) set rule.

cc @sefidel and @fran-miao

@OrangeX4 OrangeX4 linked an issue Apr 4, 2024 that may be closed by this pull request
@OrangeX4
Copy link
Member Author

OrangeX4 commented Apr 4, 2024

image
image
image
image
image

Copy link

@sefidel sefidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested functionality on simple theme.

@OrangeX4 OrangeX4 merged commit 9851442 into main Apr 4, 2024
@OrangeX4 OrangeX4 deleted the remove-padding branch April 9, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: footnotes doesn't appear since 0.3.0
2 participants