Skip to content

Commit

Permalink
Linux Validation Support
Browse files Browse the repository at this point in the history
1. Don't create a message manager in the DSP thread
2. Set validation level to 1 for linux since the leak of a
   Glyph (run the standalone and quit to see it) holds a timer
   in UI tests it seems
3. Add the Standalone to the CMake
  • Loading branch information
baconpaul committed Apr 2, 2023
1 parent dec63c1 commit 6828247
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 9 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/cmake_ctest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,16 @@ jobs:
include:
- name: Linux
os: ubuntu-22.04
#pluginval-binary: ./pluginval
pluginval-binary: ./pluginval
pluginval-strictness: 1
- name: macOS
os: macos-12
pluginval-binary: pluginval.app/Contents/MacOS/pluginval
pluginval-strictness: 10
- name: windows
os: windows-latest
pluginval-binary: ./pluginval.exe
pluginval-strictness: 1

steps:
- name: Set up Clang
Expand Down Expand Up @@ -134,7 +137,7 @@ jobs:
run: |
curl -LO "https://github.com/Tracktion/pluginval/releases/download/v1.0.1/pluginval_${{ matrix.name }}.zip"
7z x pluginval_${{ matrix.name }}.zip
${{ matrix.pluginval-binary }} --strictness-level 10 --verbose --validate "${{ env.VST3_PATH }}"
${{ matrix.pluginval-binary }} --strictness-level ${{ matrix.pluginval-strictness }} --verbose --validate "${{ env.VST3_PATH }}"
- name: Codesign (macOS)
working-directory: ${{ env.BUILD_DIR }}
Expand Down
4 changes: 2 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ set(PROJECT_NAME "Valentine")

# Set the plugin formats you'll be building here.
# Valid formats: AAX Unity VST AU AUv3 Standalone
set(FORMATS AU VST3)
set(FORMATS AU VST3 Standalone)

# Reads in VERSION file and sticks in it CURRENT_VERSION variable
# Be sure the file has no newlines
Expand Down Expand Up @@ -177,7 +177,7 @@ target_compile_definitions("${PROJECT_NAME}"
JUCE_ENABLE_GPL_MODE=1
JUCE_DISPLAY_SPLASH_SCREEN=0
JUCE_REPORT_APP_USAGE=0
JUCE_MODAL_LOOPS_PERMITTED=1
JUCE_MODAL_LOOPS_PERMITTED=1 # sigh
)


Expand Down
3 changes: 0 additions & 3 deletions src/PluginProcessor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,13 @@ ValentineAudioProcessor::~ValentineAudioProcessor()
{
treeState.removeParameterListener (param, this);
}

testManager->deleteInstance();
}

//==============================================================================

juce::AudioProcessorValueTreeState::ParameterLayout
ValentineAudioProcessor::createParameterLayout()
{
testManager = juce::MessageManager::getInstance();
std::vector<std::unique_ptr<juce::RangedAudioParameter>> params;

for (size_t i = 0; i < numParams; ++i)
Expand Down
2 changes: 0 additions & 2 deletions src/PluginProcessor.h
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,5 @@ class ValentineAudioProcessor : public juce::AudioProcessor,
std::unique_ptr<SimpleZOH> simpleZOH;
std::unique_ptr<Bitcrusher> bitCrush;

juce::MessageManager* testManager;

JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (ValentineAudioProcessor)
};

0 comments on commit 6828247

Please sign in to comment.