Skip to content

Commit

Permalink
Merge pull request #26 from baconpaul/linux-validates
Browse files Browse the repository at this point in the history
Linux Validation Support
  • Loading branch information
JoseDiazRohena authored Apr 4, 2023
2 parents fa27896 + 91b69ab commit 62f98be
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 8 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/cmake_ctest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,16 @@ jobs:
include:
- name: Linux
os: ubuntu-22.04
#pluginval-binary: ./pluginval
pluginval-binary: ./pluginval
pluginval-strictness: 1
- name: macOS
os: macos-12
pluginval-binary: pluginval.app/Contents/MacOS/pluginval
pluginval-strictness: 10
- name: windows
os: windows-latest
pluginval-binary: ./pluginval.exe
pluginval-strictness: 10

steps:
- name: Set up Clang
Expand Down Expand Up @@ -134,7 +137,7 @@ jobs:
run: |
curl -LO "https://github.com/Tracktion/pluginval/releases/download/v1.0.1/pluginval_${{ matrix.name }}.zip"
7z x pluginval_${{ matrix.name }}.zip
${{ matrix.pluginval-binary }} --strictness-level 10 --verbose --validate "${{ env.VST3_PATH }}"
${{ matrix.pluginval-binary }} --strictness-level ${{ matrix.pluginval-strictness }} --verbose --validate "${{ env.VST3_PATH }}"
- name: Codesign (macOS)
working-directory: ${{ env.BUILD_DIR }}
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ set(PROJECT_NAME "Valentine")

# Set the plugin formats you'll be building here.
# Valid formats: AAX Unity VST AU AUv3 Standalone
set(FORMATS AU VST3)
set(FORMATS AU VST3 Standalone)

# Reads in VERSION file and sticks in it CURRENT_VERSION variable
# Be sure the file has no newlines
Expand Down
3 changes: 0 additions & 3 deletions src/PluginProcessor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,13 @@ ValentineAudioProcessor::~ValentineAudioProcessor()
{
treeState.removeParameterListener (param, this);
}

testManager->deleteInstance();
}

//==============================================================================

juce::AudioProcessorValueTreeState::ParameterLayout
ValentineAudioProcessor::createParameterLayout()
{
testManager = juce::MessageManager::getInstance();
std::vector<std::unique_ptr<juce::RangedAudioParameter>> params;

for (size_t i = 0; i < numParams; ++i)
Expand Down
2 changes: 0 additions & 2 deletions src/PluginProcessor.h
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,5 @@ class ValentineAudioProcessor : public juce::AudioProcessor,
std::unique_ptr<SimpleZOH> simpleZOH;
std::unique_ptr<Bitcrusher> bitCrush;

juce::MessageManager* testManager;

JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (ValentineAudioProcessor)
};

0 comments on commit 62f98be

Please sign in to comment.