Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(configs/eslint-config): fix and add eslint-plugin-react-hooks recommended rules #1399

Merged

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Dec 19, 2024

Overview

  • fix and add eslint-plugin-react-hooks recommended rules

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

@sukvvon sukvvon requested a review from manudeli as a code owner December 19, 2024 02:03
Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: bdfb627

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

coauthors bot commented Dec 19, 2024

People can be co-author:

Candidate Reasons Count Add this as commit message
@sukvvon #1399 1 Co-authored-by: sukvvon <66409882+sukvvon@users.noreply.github.com>
@codecov-commenter #1399 (comment) 1 Co-authored-by: codecov-commenter <65553080+codecov-commenter@users.noreply.github.com>
@manudeli #1399 (review) 1 Co-authored-by: manudeli <61593290+manudeli@users.noreply.github.com>

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suspensive.org ❌ Failed (Inspect) Dec 19, 2024 3:57am
v1.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 3:57am
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 3:57am

Copy link

vercel bot commented Dec 19, 2024

@sukvvon is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.93%. Comparing base (a8f476c) to head (bdfb627).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1399   +/-   ##
=======================================
  Coverage   73.93%   73.93%           
=======================================
  Files          70       70           
  Lines         587      587           
  Branches      129      129           
=======================================
  Hits          434      434           
  Misses        141      141           
  Partials       12       12           
Components Coverage Δ
@suspensive/react 100.00% <ø> (ø)
@suspensive/react-dom 95.55% <ø> (ø)
@suspensive/react-native 100.00% <ø> (ø)
@suspensive/react-query 83.47% <ø> (ø)
@suspensive/react-query-4 0.00% <ø> (ø)
@suspensive/react-query-5 0.00% <ø> (ø)
@suspensive/jotai 0.00% <ø> (ø)
@suspensive/codemods 41.97% <ø> (ø)

Copy link
Member

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!👍

@manudeli manudeli merged commit bdd66de into toss:main Dec 19, 2024
14 checks passed
@sukvvon sukvvon deleted the chore/add-reactHooks-right-in-eslint-config branch December 19, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants