Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Update pnpm v8 to v9 #1199

Closed
sungh0lim opened this issue Aug 6, 2024 · 12 comments · Fixed by #1212
Closed

[Feature]: Update pnpm v8 to v9 #1199

sungh0lim opened this issue Aug 6, 2024 · 12 comments · Fixed by #1212
Assignees

Comments

@sungh0lim
Copy link
Contributor

Package Scope

etc

Description

Have you looked at the release of pnpm v9.0.0 by any chance?

These changes will be good for suspensive.

  • Corepack compatiblity
  • Lockfile changes

Possible Solution

No response

etc.

No response

@manudeli
Copy link
Member

manudeli commented Aug 6, 2024

Thanks for your suggestion. Already I knew it. but It had bug for our release process related with pnpm 9. and Suspensive use peerDependency as very seriously

image

When this bug fixed, I'll try it 🙇

@manudeli
Copy link
Member

manudeli commented Aug 6, 2024

Your contribution will be also good for us if you okay! 👍

@sungh0lim
Copy link
Contributor Author

Could you explain bug with peerDependency?

@manudeli
Copy link
Member

manudeli commented Aug 6, 2024

Could you explain bug with peerDependency?

When using PNPM 9, workspace:^2.9.0 changes to ^2.9.02.9.0 at publish time. Our expected outcome was ^2.9.0, and this worked correctly in PNPM 8. 🥲

@sungh0lim
Copy link
Contributor Author

I'll try it this weekend :)

@gwansikk
Copy link
Collaborator

gwansikk commented Aug 6, 2024

@gwansikk
Copy link
Collaborator

gwansikk commented Aug 7, 2024

When using PNPM 9, workspace:^2.9.0 changes to ^2.9.02.9.0 at publish time. Our expected outcome was ^2.9.0, and this worked correctly in PNPM 8. 🥲

@manudeli @sungh0lim I'm working on trying to resolve that issue.

@manudeli
Copy link
Member

@gwansikk's pull request is merged. let's do this issue. I'll assign @sungh0lim on this issue

@sungh0lim
Copy link
Contributor Author

@gwansikk It's so cool!!! When pnpm/pnpm#8383 deployed, I update pnpm version of suspensive.

@gwansikk
Copy link
Collaborator

@gwansikk It's so cool!!! When pnpm/pnpm#8383 deployed, I update pnpm version of suspensive.

It has been released with pnpm@9.7.1!​

manudeli added a commit that referenced this issue Aug 16, 2024
close #1199

Co-authored-by: GwanSik Kim <39869096+gwansikk@users.noreply.github.com>
Co-authored-by: 임성호 (삼바) <70130721+sungh0lim@users.noreply.github.com>
@manudeli
Copy link
Member

coauthors test

Copy link

coauthors bot commented Aug 16, 2024

People can be co-author:

Candidate Reasons Count Add this as commit message
@sungh0lim #1199 (comment) #1199 (comment) #1199 (comment) #1199 4 Co-authored-by: sungh0lim <70130721+sungh0lim@users.noreply.github.com>
@manudeli #1199 (comment) #1199 (comment) #1199 (comment) #1199 (comment) #1199 (comment) 5 Co-authored-by: manudeli <61593290+manudeli@users.noreply.github.com>
@gwansikk #1199 (comment) #1199 (comment) #1199 (comment) 3 Co-authored-by: gwansikk <39869096+gwansikk@users.noreply.github.com>

2-NOW pushed a commit to 2-NOW/suspensive that referenced this issue Aug 16, 2024
close toss#1199

---------

Co-authored-by: GwanSik Kim <39869096+gwansikk@users.noreply.github.com>
Co-authored-by: 임성호 (삼바) <70130721+sungh0lim@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants