fix: state reset issue on overlay reopen #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes an issue where overlays did not retain their state when reopened without unmounting, even though they were not removed from the DOM. The overlayReducer has been updated to maintain the state of overlays between close and open cycles, addressing an unintended state reset.
Related Issue: Fixes #57
Changes
overlayData
. If the overlay exists, its state is retained.Motivation and Context
This change is necessary to ensure that the overlay components behave as expected across user interactions.
How Has This Been Tested?
Screenshots (if appropriate):
2024-07-14.8.22.10.mov
Types of changes
Checklist
Further Comments