Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change current value when closing overlay #48

Merged
merged 3 commits into from
Jul 13, 2024

Conversation

jungpaeng
Copy link
Member

close: #44

@jungpaeng jungpaeng self-assigned this Jul 13, 2024
Copy link

vercel bot commented Jul 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
overlay-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2024 2:57pm

Copy link

changeset-bot bot commented Jul 13, 2024

🦋 Changeset detected

Latest commit: 567d7df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
overlay-kit Patch
@overlay-kit/framer-motion Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@jgjgill jgjgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thank you for the quick work. I have checked it out. 🙇‍♂️
I'll write some test code to make the code more stable. 😆

@jungpaeng jungpaeng merged commit 2aaa5ea into main Jul 13, 2024
2 checks passed
@jungpaeng jungpaeng deleted the fix/change-current-on-close branch July 13, 2024 16:06
@github-actions github-actions bot mentioned this pull request Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is the intended behavior that firing a close event does not change current?
2 participants