Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench mark를 실행할 수 있도록 환경을 세팅합니다 #261

Merged
merged 5 commits into from
Nov 1, 2024
Merged

Conversation

okinawaa
Copy link
Member

Overview

fix #260

image

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

Copy link

changeset-bot bot commented Oct 31, 2024

⚠️ No Changeset found

Latest commit: fbacc7d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 2:16pm

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.53%. Comparing base (821267d) to head (fbacc7d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   99.53%   99.53%           
=======================================
  Files          38       38           
  Lines         639      639           
  Branches      153      154    +1     
=======================================
  Hits          636      636           
  Misses          3        3           

@po4tion
Copy link
Collaborator

po4tion commented Nov 1, 2024

@okinawaa 님 벤치마크 기능은 es-hangul을 사용할 때 사용자들에게 신뢰성을 줄 수 있을 것 같아 매우 좋아보여요! 한가지 궁금한 점이 있다면, 벤치마킹을 위한 라이브러리를 선택한 기준이 무엇일까요?

@okinawaa
Copy link
Member Author

okinawaa commented Nov 1, 2024

@po4tion 기존에 테스트를 위해서 사용하던 vitest가 2버전대로 되면서 bench도 제공해줘서 사용했어요~!

@okinawaa okinawaa merged commit ab36228 into main Nov 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants