Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Oranda, fix syntax highlighting #304

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Conversation

hawkw
Copy link
Contributor

@hawkw hawkw commented Jan 19, 2024

  • chore: update Oranda

    This commit updates Oranda from v0.3.1 to v0.6.1. I don't believe any of
    the new Oranda features are particularly relevant to us, but there are
    some nice bugfixes, including draft mdBook chapter titles are unreadable in oranda-dark and oranda-light mdBook theme axodotdev/oranda#654, which fixes
    unreadable CSS colors for mdBook draft chapters in the Oranda CSS themes
    which we use.

    Also, since Fix the tailwind dependency breaking the Nix flake axodotdev/oranda#609 has merged upstream, we can change the
    Nix flake to depend on upstream Oranda rather than my fork.

  • docs: change "console" markdown syntax to "shell"

    Oranda doesn't know how to highlight "console", it does know how to
    highlight "shell":

      esp32c3-buddy ⚠ >o_o< WARNING: Found syntax highlight language annotation `console` which is not currently supported. The annotated block will be shown as plaintext. Please file an issue https://github.com/axodotdev/oranda/issues/new to let us know you'd like to see it supported.
      esp32c3-buddy ⚠ >o_o< WARNING: Found syntax highlight language annotation `console` which is not currently supported. The annotated block will be shown as plaintext. Please file an issue https://github.com/axodotdev/oranda/issues/new to let us know you'd like to see it supported.
      esp32c3-buddy ⚠ >o_o< WARNING: Found syntax highlight language annotation `console` which is not currently supported. The annotated block will be shown as plaintext. Please file an issue https://github.com/axodotdev/oranda/issues/new to let us know you'd like to see it supported.
      esp32c3-buddy ⚠ >o_o< WARNING: Found syntax highlight language annotation `console` which is not currently supported. The annotated block will be shown as plaintext. Please file an issue https://github.com/axodotdev/oranda/issues/new to let us know you'd like to see it supported.
      esp32c3-buddy ⚠ >o_o< WARNING: Found syntax highlight language annotation `console` which is not currently supported. The annotated block will be shown as plaintext. Please file an issue https://github.com/axodotdev/oranda/issues/new to let us know you'd like to see it supported.
    

    GitHub's Markdown renderer treats these as equivalent, so switching the
    code blocks currently marked as "console" to "shell" results in much
    nicer syntax highlighting in the Oranda site without changing the way
    the READMEs look on GitHub.

hawkw added 2 commits January 19, 2024 10:12
This commit updates Oranda from v0.3.1 to v0.6.1. I don't believe any of
the new Oranda features are particularly relevant to us, but there are
some nice bugfixes, including axodotdev/oranda#654, which fixes
unreadable CSS colors for mdBook draft chapters in the Oranda CSS themes
which we use.

Also, since axodotdev/oranda#609 has merged upstream, we can change the
Nix flake to depend on upstream Oranda rather than my fork.
Oranda doesn't know how to highlight "console", it does know how to
highlight "shell":

```
  esp32c3-buddy ⚠ >o_o< WARNING: Found syntax highlight language annotation `console` which is not currently supported. The annotated block will be shown as plaintext. Please file an issue https://github.com/axodotdev/oranda/issues/new to let us know you'd like to see it supported.
  esp32c3-buddy ⚠ >o_o< WARNING: Found syntax highlight language annotation `console` which is not currently supported. The annotated block will be shown as plaintext. Please file an issue https://github.com/axodotdev/oranda/issues/new to let us know you'd like to see it supported.
  esp32c3-buddy ⚠ >o_o< WARNING: Found syntax highlight language annotation `console` which is not currently supported. The annotated block will be shown as plaintext. Please file an issue https://github.com/axodotdev/oranda/issues/new to let us know you'd like to see it supported.
  esp32c3-buddy ⚠ >o_o< WARNING: Found syntax highlight language annotation `console` which is not currently supported. The annotated block will be shown as plaintext. Please file an issue https://github.com/axodotdev/oranda/issues/new to let us know you'd like to see it supported.
  esp32c3-buddy ⚠ >o_o< WARNING: Found syntax highlight language annotation `console` which is not currently supported. The annotated block will be shown as plaintext. Please file an issue https://github.com/axodotdev/oranda/issues/new to let us know you'd like to see it supported.
  ```

GitHub's Markdown renderer treats these as equivalent, so switching the
code blocks currently marked as "console" to "shell" results in much
nicer syntax highlighting in the Oranda site without changing the way
the READMEs look on GitHub.
@hawkw hawkw force-pushed the eliza/update-oranda branch from 6319092 to 3b45e2b Compare January 19, 2024 18:13
@hawkw hawkw enabled auto-merge (rebase) January 19, 2024 18:13
@hawkw hawkw disabled auto-merge January 19, 2024 18:52
@hawkw hawkw merged commit 563cb0f into main Jan 19, 2024
10 checks passed
@hawkw hawkw deleted the eliza/update-oranda branch January 19, 2024 18:52
hawkw added a commit that referenced this pull request Jan 19, 2024
This commit updates Oranda from v0.3.1 to v0.6.1. I don't believe any of
the new Oranda features are particularly relevant to us, but there are
some nice bugfixes, including axodotdev/oranda#654, which fixes
unreadable CSS colors for mdBook draft chapters in the Oranda CSS themes
which we use.

Also, since axodotdev/oranda#609 has merged upstream, we can change the
Nix flake to depend on upstream Oranda rather than my fork.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant