Skip to content

Commit

Permalink
hwmon: (bt1-pvt) Remove redundant error printing in pvt_request_regs()
Browse files Browse the repository at this point in the history
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20210511091843.4561-1-thunder.leizhen@huawei.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
  • Loading branch information
Zhen Lei authored and groeck committed Jun 17, 2021
1 parent ea541c1 commit 4943c60
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/hwmon/bt1-pvt.c
Original file line number Diff line number Diff line change
Expand Up @@ -924,10 +924,8 @@ static int pvt_request_regs(struct pvt_hwmon *pvt)
}

pvt->regs = devm_ioremap_resource(pvt->dev, res);
if (IS_ERR(pvt->regs)) {
dev_err(pvt->dev, "Couldn't map PVT registers\n");
if (IS_ERR(pvt->regs))
return PTR_ERR(pvt->regs);
}

return 0;
}
Expand Down

0 comments on commit 4943c60

Please sign in to comment.