-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Drop py35 #190
Conversation
Pull Request Test Coverage Report for Build 797
💛 - Coveralls |
@abondar This PR has two basic things:
I am going to split this up into the tests & bugfixes (backport for 0.13.6). But please have a look at this PR :-) |
Looks all good to me |
Yes, the speedup was mainly on two "special" cases:
This gave a better speedup with larger models with more fields. We could probably do a similar speedup for creating from Python via the constructor, and the converting to the DB fields. But we are running out of Python-level inefficiencies to optimize. We'll soon have to expand the benchmarking system to test DB/connector/Tortoise interactions. e.g. Are we using the indexes correctly? Is there any unnecessary overhead with the DB connectors for MySQL/PostgreSQL? Do we set up the DB fields correctly for case-insensitive operations? etc... |
The plan is to have this as the next master base. I'm leaving this here as a PR so its easier to manage.
DONE:
flynt
andpyupgrade
to help automate)Model._init_from_db
to minimize callingto_python_value
if we have guarantees that allow for it to be skipped.