Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homepage hero element is not like the design #51

Closed
2 tasks
josecelano opened this issue Sep 27, 2024 · 0 comments · Fixed by #68
Closed
2 tasks

Homepage hero element is not like the design #51

josecelano opened this issue Sep 27, 2024 · 0 comments · Fixed by #68
Assignees
@grmbyrn
Labels
Bug Incorrect Behaviour
Milestone
v3.0.0

Comments

@josecelano
Copy link
Member

Left: current
Right: design

image

  • It is still approx 10% higher
  • The background colours (ff3201, ff3100) and especially the SVG are not the same.
@josecelano josecelano added the Bug Incorrect Behaviour label Sep 27, 2024
@josecelano josecelano added this to the v3.0.0 milestone Oct 1, 2024
@grmbyrn grmbyrn mentioned this issue Oct 2, 2024
Merged
@josecelano josecelano linked a pull request Oct 3, 2024 that will close this issue
fix issues #68
Merged
josecelano added a commit that referenced this issue Oct 3, 2024
@josecelano
Merge #68: fix issues
4fbfc01 
36e1da4 fix favicon issue (Graeme Byrne)
1ce0e97 fix issues (Graeme Byrne)

Pull request description:

  [Invalid URL: /undefined #5](#5)
  [Missing elements in the new design for blog posts #10](#10)
  [Remove # prefix from table of contents items #33](#33)
  [Missing paragraph separator in About page #34](#34)
  [Ask designer how to implement different types of callouts components #35](#35)
  [Blog post card size is not the same as in the design (full width) #39](#39)
  [Ask the designer how to implement a link inside a key feature card #42](#42)
  [Ask the designer how body content should look for wide screens #46](#46)
  [Homepage hero element is not like the design #51](#51)
  [Blog post footer navigation doesn't change the main image #53](#53)
  [Enable second level of indentation in TableOfContents section #58](#58)
  [Update the favicons #61](#61)
  [First card in key features is not shown #62](#62)

ACKs for top commit:
  josecelano:
    ACK 36e1da4

Tree-SHA512: 3a3665dcbb1a67b34f11ebef3ad7c801203a126219634eeb524c1739268678f3ca17d185e593e4a8e45b958e20d257e5bacb47967a616785c7d72d96cdb41609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grmbyrn grmbyrn

Labels
Bug Incorrect Behaviour
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

fix issues grmbyrn/torrust-website-v2
2 participants
@josecelano @grmbyrn