Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fielename prop in <CodeBlock> component should be optional #49

Closed
josecelano opened this issue Sep 27, 2024 · 0 comments · Fixed by #50
Closed

fielename prop in <CodeBlock> component should be optional #49

josecelano opened this issue Sep 27, 2024 · 0 comments · Fixed by #50
Assignees
@grmbyrn
Labels
Bug Incorrect Behaviour

Comments

@josecelano
Copy link
Member

image
@josecelano josecelano added the Bug Incorrect Behaviour label Sep 27, 2024
@grmbyrn grmbyrn mentioned this issue Sep 27, 2024
Merged
@josecelano josecelano linked a pull request Sep 27, 2024 that will close this issue
fix v2 issues #50
Merged
josecelano added a commit that referenced this issue Sep 27, 2024
@josecelano
Merge #50: fix v2 issues
06efe08 
cbe642e fix v2 issues (Graeme Byrne)

Pull request description:

  * change from using `window` in `TableOfContents` to using `IntersectionObserver`
  * [fielename prop in <CodeBlock> component should be optional #49](#49)
  * [Normal links don't have any special style #48](#48)
  * [Ask the designer how to implement a link inside a key feature card #42](#42)
  * [Blog post tags style is not the same as the design #38](#38)
  * [Ask the designer how to implement html lists #37](#37)
  * [Font size for table of contents is not as the design #31](#31)
  * [Ask the designer how to implement share links in blog posts #29](#29)
  * [Related Post section does not look like the standard blog post list #27](#27)
  * [Top menu padding is not the same as the design #26](#26)
  * [Key features list width should be 100% #6](#6)

ACKs for top commit:
  josecelano:
    ACK cbe642e

Tree-SHA512: 1b6df7281d9b9f0f88555874aec76fc20d2a73b098ef9112952b47fc916981c26ec63ee1197c21c1c75fd9db6c1ea1da453a91142838d11a77656c3845dbbefa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grmbyrn grmbyrn

Labels
Bug Incorrect Behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix v2 issues grmbyrn/torrust-website-v2
2 participants
@josecelano @grmbyrn