-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul core Tracker: extract stats #1184
Labels
Code Cleanup / Refactoring
Tidying and Making Neat
Comments
josecelano
added a commit
to josecelano/torrust-tracker
that referenced
this issue
Jan 16, 2025
…o the core tracker This is part of a big refactor. We are extracting responsabilities from the tracker. The first step is to inject the service into the tracker and later we will use the extracted services directly. Finally we will removed the injected service from the tracker when it's not used anymore via the tracker.
josecelano
added a commit
to josecelano/torrust-tracker
that referenced
this issue
Jan 17, 2025
josecelano
added a commit
to josecelano/torrust-tracker
that referenced
this issue
Jan 17, 2025
josecelano
added a commit
to josecelano/torrust-tracker
that referenced
this issue
Jan 17, 2025
josecelano
added a commit
to josecelano/torrust-tracker
that referenced
this issue
Jan 17, 2025
josecelano
added a commit
to josecelano/torrust-tracker
that referenced
this issue
Jan 17, 2025
josecelano
added a commit
to josecelano/torrust-tracker
that referenced
this issue
Jan 17, 2025
josecelano
added a commit
to josecelano/torrust-tracker
that referenced
this issue
Jan 17, 2025
josecelano
added a commit
to josecelano/torrust-tracker
that referenced
this issue
Jan 17, 2025
josecelano
added a commit
that referenced
this issue
Jan 17, 2025
2a0bc47 refactor: [#1184] remove stats functionality from core tracker (Jose Celano) c415430 refactor: [#1184] inject stats event sender and repository into the core tracker (Jose Celano) Pull request description: Overhaul core Tracker: extract stats ACKs for top commit: josecelano: ACK 2a0bc47 Tree-SHA512: b72acb6f25d5ea642d9889fa7da3e6602c7362c1b6381af94bac848eda5b4f1a1b1fd364660fa93f703a48bc874b883db2d14ce30e4c54352f754c72132fcac3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Parent issue: #1181
Extract the responsibility for handling stats (send events and return metrics) from the core tracker.
These two methods (
get_stats
andget_stats
) will be called directly exposing thestats_repository
andstats_event_sender
.See the previous similar refactor for reference.
Since I'm extracting a lot of code from the core Tracker now the app bootstrapping is becoming more complex because the tracker dependencies are built before instantiating the tracker. At some point I think I will create a IoC container to store all the references to services (Arc<...>).
cc @da2ce7
The text was updated successfully, but these errors were encountered: